You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Sergey Nuyanzin (JIRA)" <ji...@apache.org> on 2018/05/14 12:33:00 UTC
[jira] [Comment Edited] (CALCITE-2303) Extract for time unit:
DECADE not supported!
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474107#comment-16474107 ]
Sergey Nuyanzin edited comment on CALCITE-2303 at 5/14/18 12:32 PM:
--------------------------------------------------------------------
Sorry, it was my fault...
the question was about {code:java} EXTRACT(EPOCH FROM ts){code}
e.g. I wrote some tests like {code:java}
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(2001, 1, 1)),
is(978307200L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(2000, 12, 31)),
is(978220800L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(1852, 6, 7)),
is(584864896L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(1, 1, 1)),
is(-2006400256L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(1, 2, 1)),
is(-2003721856L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(-2, 1, 1)),
is(-2101094656L));{code}
they are passed for epoch implementation like {code:java}
case EPOCH:
return (int) (unixTimestamp(year, month, day, 0, 0, 0) / 1000); // zeros as no info about hours, minutes, seconds{code}
however the question is: should we take into account minutes, seconds, hours in case of EPOCH?
I do not see how I can write a test for that case within _org.apache.calcite.avatica.util.DateTimeUtilsTest_
however it is clear that it will fail(if minutes, hours, seconds should be considered)
I mean that e.g.
{code:java}EXTRACT(EPOCH FROM TIMESTAMP '2008-2-23 12:34:56'){code}
and
{code:java}EXTRACT(EPOCH FROM TIMESTAMP '2008-2-23 00:00:00'){code}
will return the same results
was (Author: sergey nuyanzin):
Sorry, it was my fault...
the question was about {code:java} EXTRACT(EPOCH FROM ts){code}
e.g. I wrote some tests like {code:java}
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(2001, 1, 1)),
is(978307200L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(2000, 12, 31)),
is(978220800L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(1852, 6, 7)),
is(584864896L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(1, 1, 1)),
is(-2006400256L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(1, 2, 1)),
is(-2003721856L));
assertThat(
unixDateExtract(TimeUnitRange.EPOCH, ymdToUnixDate(-2, 1, 1)),
is(-2101094656L));{code}
they are passed for epoch implementation like {code:java}
case EPOCH:
return (int) (unixTimestamp(year, month, day, 0, 0, 0) / 1000); // zeros as no info about hours, minutes, seconds{code}
however the question is: should we take into account minutes, seconds, hours in case of EPOCH?
I do see how I can write a test for such case within _org.apache.calcite.avatica.util.DateTimeUtilsTest_
however it is clear that it will fail(if minutes, hours, seconds should be considered)
I mean that e.g.
{code:java}EXTRACT(EPOCH FROM TIMESTAMP '2008-2-23 12:34:56'){code}
and
{code:java}EXTRACT(EPOCH FROM TIMESTAMP '2008-2-23 00:00:00'){code}
will return the same results
> Extract for time unit: DECADE not supported!
> --------------------------------------------
>
> Key: CALCITE-2303
> URL: https://issues.apache.org/jira/browse/CALCITE-2303
> Project: Calcite
> Issue Type: Bug
> Reporter: Sergey Nuyanzin
> Assignee: Julian Hyde
> Priority: Major
>
> Here CALCITE-1177 were supported new units
> however such test
> {code:java}
> @Test public void testDecadeFunction() throws Exception {
> ExpressionChecker checker = new ExpressionChecker()
> .addExpr("EXTRACT(DECADE FROM ts)", 199L)
> ;
> checker.buildRunAndCheck();
> }
> {code}
> failed like
> Extract for time unit: DECADE not supported!
> {noformat}
> SQL:>
> SELECT EXTRACT(DECADE FROM ts) FROM PCOLLECTION
> May 08, 2018 1:34:58 PM org.apache.beam.sdk.extensions.sql.impl.planner.BeamQueryPlanner validateAndConvert
> INFO: SQL:
> SELECT EXTRACT(DECADE FROM `PCOLLECTION`.`ts`)
> FROM `PCOLLECTION` AS `PCOLLECTION`
> May 08, 2018 1:34:58 PM org.apache.beam.sdk.extensions.sql.impl.planner.BeamQueryPlanner convertToBeamRel
> INFO: SQLPlan>
> LogicalProject(EXPR$0=[EXTRACT(FLAG(DECADE), $0)])
> BeamIOSourceRel(table=[[PCOLLECTION]])
> java.lang.RuntimeException: org.apache.beam.sdk.Pipeline$PipelineExecutionException: java.lang.UnsupportedOperationException: Extract for time unit: DECADE not supported!
> at org.apache.beam.sdk.extensions.sql.integrationtest.BeamSqlBuiltinFunctionsIntegrationTestBase$ExpressionChecker.buildRunAndCheck(BeamSqlBuiltinFunctionsIntegrationTestBase.java:167)
> at org.apache.beam.sdk.extensions.sql.integrationtest.BeamSqlDateFunctionsIntegrationTest.testDecadeFunction(BeamSqlDateFunctionsIntegrationTest.java:66)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.apache.beam.sdk.testing.TestPipeline$1.evaluate(TestPipeline.java:317)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
> at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> Caused by: org.apache.beam.sdk.Pipeline$PipelineExecutionException: java.lang.UnsupportedOperationException: Extract for time unit: DECADE not supported!
> at org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:349)
> at org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:319)
> at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:210)
> at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:66)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:311)
> at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:346)
> at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:328)
> at org.apache.beam.sdk.extensions.sql.integrationtest.BeamSqlBuiltinFunctionsIntegrationTestBase$ExpressionChecker.buildRunAndCheck(BeamSqlBuiltinFunctionsIntegrationTestBase.java:165)
> ... 25 more
> Caused by: java.lang.UnsupportedOperationException: Extract for time unit: DECADE not supported!
> at org.apache.beam.sdk.extensions.sql.impl.interpreter.operator.date.BeamSqlExtractExpression.evaluate(BeamSqlExtractExpression.java:92)
> at org.apache.beam.sdk.extensions.sql.impl.interpreter.BeamSqlFnExecutor.execute(BeamSqlFnExecutor.java:505)
> at org.apache.beam.sdk.extensions.sql.impl.transform.BeamSqlProjectFn.processElement(BeamSqlProjectFn.java:57)
> {noformat}
> I guess here _org.apache.calcite.avatica.util.DateTimeUtils#julianExtract_
> should be added something like
> {code:java}
> case DECADE:
> return year > 0
> ? (year + 9) / 10
> : (year - 9) / 10;
> {code}
> or do I do something not right?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)