You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/10/13 16:43:18 UTC
Review Request 39273: Ambari unable to build rpms with 4 digit
versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39273/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-13403
https://issues.apache.org/jira/browse/AMBARI-13403
Repository: ambari
Description
-------
Diffs
-----
ambari-admin/pom.xml 8985c1e
ambari-agent/pom.xml b544d75
ambari-client/groovy-client/pom.xml 6b08bd0
ambari-client/pom.xml 4bba701
ambari-client/python-client/pom.xml 02fa516
ambari-metrics/ambari-metrics-assembly/pom.xml dead742
ambari-metrics/ambari-metrics-common/pom.xml d47b03f
ambari-metrics/ambari-metrics-flume-sink/pom.xml af5d794
ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 62d095b
ambari-metrics/ambari-metrics-host-monitoring/pom.xml b0fe4d7
ambari-metrics/ambari-metrics-kafka-sink/pom.xml d4590d3
ambari-metrics/ambari-metrics-storm-sink/pom.xml d3ffe22
ambari-metrics/ambari-metrics-timelineservice/pom.xml 0d9f35d
ambari-metrics/pom.xml 05c2865
ambari-project/pom.xml e94bd69
ambari-server/pom.xml 0b1870b
ambari-shell/ambari-groovy-shell/pom.xml 745cd87
ambari-shell/ambari-python-shell/pom.xml 66928d0
ambari-shell/pom.xml dc90261
ambari-views/pom.xml 6fe6004
ambari-web/pom.xml 6d5bd75
docs/pom.xml 6ff75ea
pom.xml 593cd67
Diff: https://reviews.apache.org/r/39273/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 39273: Ambari unable to build rpms with 4 digit
versions
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39273/#review102450
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 13, 2015, 2:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39273/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 2:43 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13403
> https://issues.apache.org/jira/browse/AMBARI-13403
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We tried making the change but the rpms being created do not get the correct version number.
>
> The goal is to create a build with version 2.1.2.0.378. As you can see the rpms being created are with version 2.1.2-0:
> ... ambari-metrics-monitor/RPMS/x86_64/ambari-metrics-monitor-2.1.2-0.x86_64.rpm
> It seems as if the build is not processing a 4 digit version + build properly. DnewVersion=2.1.2.0.378 is being broken such that the 4th digit is becoming the build number. I suspect the replacement directive in POM needs to be changed.
>
>
> Diffs
> -----
>
> ambari-admin/pom.xml 8985c1e
> ambari-agent/pom.xml b544d75
> ambari-client/groovy-client/pom.xml 6b08bd0
> ambari-client/pom.xml 4bba701
> ambari-client/python-client/pom.xml 02fa516
> ambari-metrics/ambari-metrics-assembly/pom.xml dead742
> ambari-metrics/ambari-metrics-common/pom.xml d47b03f
> ambari-metrics/ambari-metrics-flume-sink/pom.xml af5d794
> ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 62d095b
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml b0fe4d7
> ambari-metrics/ambari-metrics-kafka-sink/pom.xml d4590d3
> ambari-metrics/ambari-metrics-storm-sink/pom.xml d3ffe22
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 0d9f35d
> ambari-metrics/pom.xml 05c2865
> ambari-project/pom.xml e94bd69
> ambari-server/pom.xml 0b1870b
> ambari-shell/ambari-groovy-shell/pom.xml 745cd87
> ambari-shell/ambari-python-shell/pom.xml 66928d0
> ambari-shell/pom.xml dc90261
> ambari-views/pom.xml 6fe6004
> ambari-web/pom.xml 6d5bd75
> docs/pom.xml 6ff75ea
> pom.xml 593cd67
>
> Diff: https://reviews.apache.org/r/39273/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 39273: Ambari unable to build rpms with 4 digit
versions
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39273/#review102486
-----------------------------------------------------------
Does this have any impact on Ambari Upgrades, say 2.0.0 to 2.1.2.1?
- Alejandro Fernandez
On Oct. 13, 2015, 2:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39273/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 2:43 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13403
> https://issues.apache.org/jira/browse/AMBARI-13403
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We tried making the change but the rpms being created do not get the correct version number.
>
> The goal is to create a build with version 2.1.2.0.378. As you can see the rpms being created are with version 2.1.2-0:
> ... ambari-metrics-monitor/RPMS/x86_64/ambari-metrics-monitor-2.1.2-0.x86_64.rpm
> It seems as if the build is not processing a 4 digit version + build properly. DnewVersion=2.1.2.0.378 is being broken such that the 4th digit is becoming the build number. I suspect the replacement directive in POM needs to be changed.
>
>
> Diffs
> -----
>
> ambari-admin/pom.xml 8985c1e
> ambari-agent/pom.xml b544d75
> ambari-client/groovy-client/pom.xml 6b08bd0
> ambari-client/pom.xml 4bba701
> ambari-client/python-client/pom.xml 02fa516
> ambari-metrics/ambari-metrics-assembly/pom.xml dead742
> ambari-metrics/ambari-metrics-common/pom.xml d47b03f
> ambari-metrics/ambari-metrics-flume-sink/pom.xml af5d794
> ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 62d095b
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml b0fe4d7
> ambari-metrics/ambari-metrics-kafka-sink/pom.xml d4590d3
> ambari-metrics/ambari-metrics-storm-sink/pom.xml d3ffe22
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 0d9f35d
> ambari-metrics/pom.xml 05c2865
> ambari-project/pom.xml e94bd69
> ambari-server/pom.xml 0b1870b
> ambari-shell/ambari-groovy-shell/pom.xml 745cd87
> ambari-shell/ambari-python-shell/pom.xml 66928d0
> ambari-shell/pom.xml dc90261
> ambari-views/pom.xml 6fe6004
> ambari-web/pom.xml 6d5bd75
> docs/pom.xml 6ff75ea
> pom.xml 593cd67
>
> Diff: https://reviews.apache.org/r/39273/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 39273: Ambari unable to build rpms with 4 digit
versions
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39273/#review102456
-----------------------------------------------------------
pom.xml (line 24)
<https://reviews.apache.org/r/39273/#comment160124>
Can we leave it at 2.1.0.0.0? I assume its 5 digit because the 5th one is build number?
- Sumit Mohanty
On Oct. 13, 2015, 2:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39273/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 2:43 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13403
> https://issues.apache.org/jira/browse/AMBARI-13403
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We tried making the change but the rpms being created do not get the correct version number.
>
> The goal is to create a build with version 2.1.2.0.378. As you can see the rpms being created are with version 2.1.2-0:
> ... ambari-metrics-monitor/RPMS/x86_64/ambari-metrics-monitor-2.1.2-0.x86_64.rpm
> It seems as if the build is not processing a 4 digit version + build properly. DnewVersion=2.1.2.0.378 is being broken such that the 4th digit is becoming the build number. I suspect the replacement directive in POM needs to be changed.
>
>
> Diffs
> -----
>
> ambari-admin/pom.xml 8985c1e
> ambari-agent/pom.xml b544d75
> ambari-client/groovy-client/pom.xml 6b08bd0
> ambari-client/pom.xml 4bba701
> ambari-client/python-client/pom.xml 02fa516
> ambari-metrics/ambari-metrics-assembly/pom.xml dead742
> ambari-metrics/ambari-metrics-common/pom.xml d47b03f
> ambari-metrics/ambari-metrics-flume-sink/pom.xml af5d794
> ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 62d095b
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml b0fe4d7
> ambari-metrics/ambari-metrics-kafka-sink/pom.xml d4590d3
> ambari-metrics/ambari-metrics-storm-sink/pom.xml d3ffe22
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 0d9f35d
> ambari-metrics/pom.xml 05c2865
> ambari-project/pom.xml e94bd69
> ambari-server/pom.xml 0b1870b
> ambari-shell/ambari-groovy-shell/pom.xml 745cd87
> ambari-shell/ambari-python-shell/pom.xml 66928d0
> ambari-shell/pom.xml dc90261
> ambari-views/pom.xml 6fe6004
> ambari-web/pom.xml 6d5bd75
> docs/pom.xml 6ff75ea
> pom.xml 593cd67
>
> Diff: https://reviews.apache.org/r/39273/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 39273: Ambari unable to build rpms with 4 digit
versions
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39273/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 2:43 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-13403
https://issues.apache.org/jira/browse/AMBARI-13403
Repository: ambari
Description (updated)
-------
We tried making the change but the rpms being created do not get the correct version number.
The goal is to create a build with version 2.1.2.0.378. As you can see the rpms being created are with version 2.1.2-0:
... ambari-metrics-monitor/RPMS/x86_64/ambari-metrics-monitor-2.1.2-0.x86_64.rpm
It seems as if the build is not processing a 4 digit version + build properly. DnewVersion=2.1.2.0.378 is being broken such that the 4th digit is becoming the build number. I suspect the replacement directive in POM needs to be changed.
Diffs
-----
ambari-admin/pom.xml 8985c1e
ambari-agent/pom.xml b544d75
ambari-client/groovy-client/pom.xml 6b08bd0
ambari-client/pom.xml 4bba701
ambari-client/python-client/pom.xml 02fa516
ambari-metrics/ambari-metrics-assembly/pom.xml dead742
ambari-metrics/ambari-metrics-common/pom.xml d47b03f
ambari-metrics/ambari-metrics-flume-sink/pom.xml af5d794
ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 62d095b
ambari-metrics/ambari-metrics-host-monitoring/pom.xml b0fe4d7
ambari-metrics/ambari-metrics-kafka-sink/pom.xml d4590d3
ambari-metrics/ambari-metrics-storm-sink/pom.xml d3ffe22
ambari-metrics/ambari-metrics-timelineservice/pom.xml 0d9f35d
ambari-metrics/pom.xml 05c2865
ambari-project/pom.xml e94bd69
ambari-server/pom.xml 0b1870b
ambari-shell/ambari-groovy-shell/pom.xml 745cd87
ambari-shell/ambari-python-shell/pom.xml 66928d0
ambari-shell/pom.xml dc90261
ambari-views/pom.xml 6fe6004
ambari-web/pom.xml 6d5bd75
docs/pom.xml 6ff75ea
pom.xml 593cd67
Diff: https://reviews.apache.org/r/39273/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk