You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/19 22:40:47 UTC

[GitHub] [geode] jinmeiliao commented on a diff in pull request #7603: GEODE-10243: Fail early if old client auth expires

jinmeiliao commented on code in PR #7603:
URL: https://github.com/apache/geode/pull/7603#discussion_r853540539


##########
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageDispatcher.java:
##########
@@ -533,21 +534,24 @@ private boolean handleAuthenticationExpiredException(AuthenticationExpiredExcept
       throws InterruptedException {
     long reAuthenticateWaitTime =
         getSystemProperty(RE_AUTHENTICATE_WAIT_TIME, DEFAULT_RE_AUTHENTICATE_WAIT_TIME);
+    // for old client, don't wait for re-auth but unregister this proxy completely.
+    if (getProxy().getVersion().isOlderThan(RE_AUTHENTICATION_START_VERSION)) {
+      synchronized (_stopDispatchingLock) {
+        logger.warn(OLD_CLIENT_AUTHENTICATION_EXPIRED);

Review Comment:
   cherry picked from Dan's PR. I guess it's not needed to be a constant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org