You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stefan Seidel (JIRA)" <ji...@codehaus.org> on 2008/02/01 10:37:58 UTC

[jira] Created: (SUREFIRE-449) In multi-module projects, all tests are run for each module in the module tree

In multi-module projects, all tests are run for each module in the module tree
------------------------------------------------------------------------------

                 Key: SUREFIRE-449
                 URL: http://jira.codehaus.org/browse/SUREFIRE-449
             Project: Maven Surefire
          Issue Type: Bug
          Components: report plugin
    Affects Versions: 2.4
         Environment: Maven 2.0.8, Linux
            Reporter: Stefan Seidel
            Priority: Blocker
         Attachments: mvnexec.zip

In a multi-module project, since version 2.4, all tests of all modules are run once for each module. This is *very* bad with many modules & many tests. Attached is a sample project which contains a parent module and two child modules. Each of the child modules contains one JUnit test. mvn clean site runs each test three times (once for the parent and once for each of the two submodules). When changing the surefire-report-plugin to version 2.3, each test is run only once, as it is supposed to

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-449) In multi-module projects, all tests are run for each module in the module tree

Posted by "Stefan Seidel (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122546 ] 

Stefan Seidel commented on SUREFIRE-449:
----------------------------------------

Thanks for investigating, Dan. I don't know much about maven plugin dev, but I suspected something like that. Would you agree that this is a serious flaw in maven core? I mean, would it ever make sense to execute a plugin in that way only because it has that @aggregator annotation? I think the same issue (with @aggregator) could be the cause for MJAVADOC-171. I just don't know enough to report this more general bug, but maybe you or someone from the team could?

> In multi-module projects, all tests are run for each module in the module tree
> ------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-449
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-449
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: report plugin
>    Affects Versions: 2.4
>         Environment: Maven 2.0.8, Linux
>            Reporter: Stefan Seidel
>            Priority: Blocker
>             Fix For: 2.4.2
>
>         Attachments: mvnexec.zip
>
>
> In a multi-module project, since version 2.4, all tests of all modules are run once for each module. This is *very* bad with many modules & many tests. Attached is a sample project which contains a parent module and two child modules. Each of the child modules contains one JUnit test. mvn clean site runs each test three times (once for the parent and once for each of the two submodules). When changing the surefire-report-plugin to version 2.3, each test is run only once, as it is supposed to

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-449) In multi-module projects, all tests are run for each module in the module tree

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122704 ] 

Dan Fabulich commented on SUREFIRE-449:
---------------------------------------

I stripped off @aggregator in revision 619233; that seems to fix your problem.

I'm still not entirely certain I understood this problem; here's a link to the mailing list discussion on this topic:

http://www.nabble.com/%40aggregator-mojo-annotation-td15302246s177.html

> In multi-module projects, all tests are run for each module in the module tree
> ------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-449
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-449
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: report plugin
>    Affects Versions: 2.4
>         Environment: Maven 2.0.8, Linux
>            Reporter: Stefan Seidel
>            Priority: Blocker
>             Fix For: 2.4.2
>
>         Attachments: mvnexec.zip
>
>
> In a multi-module project, since version 2.4, all tests of all modules are run once for each module. This is *very* bad with many modules & many tests. Attached is a sample project which contains a parent module and two child modules. Each of the child modules contains one JUnit test. mvn clean site runs each test three times (once for the parent and once for each of the two submodules). When changing the surefire-report-plugin to version 2.3, each test is run only once, as it is supposed to

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-449) In multi-module projects, all tests are run for each module in the module tree

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122513 ] 

Dan Fabulich commented on SUREFIRE-449:
---------------------------------------

This is happening because I added @aggregator to surefire-report in order to fix SUREFIRE-268.  I didn't really know what I was doing there, and I'm really not clear on why this causes the problem, but removing the line seems to help.  I'll need to do more research to make sure this is safe.

> In multi-module projects, all tests are run for each module in the module tree
> ------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-449
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-449
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: report plugin
>    Affects Versions: 2.4
>         Environment: Maven 2.0.8, Linux
>            Reporter: Stefan Seidel
>            Priority: Blocker
>             Fix For: 2.4.2
>
>         Attachments: mvnexec.zip
>
>
> In a multi-module project, since version 2.4, all tests of all modules are run once for each module. This is *very* bad with many modules & many tests. Attached is a sample project which contains a parent module and two child modules. Each of the child modules contains one JUnit test. mvn clean site runs each test three times (once for the parent and once for each of the two submodules). When changing the surefire-report-plugin to version 2.3, each test is run only once, as it is supposed to

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-449) In multi-module projects, all tests are run for each module in the module tree

Posted by "Luc Willems (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=153225#action_153225 ] 

Luc Willems commented on SUREFIRE-449:
--------------------------------------

Hello all ,

i'm currently using 2.4.2 version of the plugin but still seeing builds of ALL modules.
i have a complex multi module project with 3 levels of if grandParent -> parent -> child relations.
i'm using Continuum build server and use 

 mvn clean site-deploy

as goals to run.

i'm not using the report-only options. 







> In multi-module projects, all tests are run for each module in the module tree
> ------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-449
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-449
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: report plugin
>    Affects Versions: 2.4
>         Environment: Maven 2.0.8, Linux
>            Reporter: Stefan Seidel
>            Priority: Blocker
>             Fix For: 2.4.2
>
>         Attachments: mvnexec.zip
>
>
> In a multi-module project, since version 2.4, all tests of all modules are run once for each module. This is *very* bad with many modules & many tests. Attached is a sample project which contains a parent module and two child modules. Each of the child modules contains one JUnit test. mvn clean site runs each test three times (once for the parent and once for each of the two submodules). When changing the surefire-report-plugin to version 2.3, each test is run only once, as it is supposed to

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SUREFIRE-449) In multi-module projects, all tests are run for each module in the module tree

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich closed SUREFIRE-449.
---------------------------------

    Resolution: Fixed

> In multi-module projects, all tests are run for each module in the module tree
> ------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-449
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-449
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: report plugin
>    Affects Versions: 2.4
>         Environment: Maven 2.0.8, Linux
>            Reporter: Stefan Seidel
>            Priority: Blocker
>             Fix For: 2.4.2
>
>         Attachments: mvnexec.zip
>
>
> In a multi-module project, since version 2.4, all tests of all modules are run once for each module. This is *very* bad with many modules & many tests. Attached is a sample project which contains a parent module and two child modules. Each of the child modules contains one JUnit test. mvn clean site runs each test three times (once for the parent and once for each of the two submodules). When changing the surefire-report-plugin to version 2.3, each test is run only once, as it is supposed to

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-449) In multi-module projects, all tests are run for each module in the module tree

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich updated SUREFIRE-449:
----------------------------------

    Fix Version/s: 2.4.2

Thanks for filing this bug; I noticed it too but thought it was just SUREFIRE-257 (which is really a bug in core).  But I'm able to reproduce your findings that this wasn't a problem in 2.3, so I'll happily take a crack at it.

> In multi-module projects, all tests are run for each module in the module tree
> ------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-449
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-449
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: report plugin
>    Affects Versions: 2.4
>         Environment: Maven 2.0.8, Linux
>            Reporter: Stefan Seidel
>            Priority: Blocker
>             Fix For: 2.4.2
>
>         Attachments: mvnexec.zip
>
>
> In a multi-module project, since version 2.4, all tests of all modules are run once for each module. This is *very* bad with many modules & many tests. Attached is a sample project which contains a parent module and two child modules. Each of the child modules contains one JUnit test. mvn clean site runs each test three times (once for the parent and once for each of the two submodules). When changing the surefire-report-plugin to version 2.3, each test is run only once, as it is supposed to

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira