[jira] [Issue Comment Edited] (AMQ-3135) ActiveMQ.Advisory.Connection messages should contain client ip/host

["Dejan Bosanac (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049752#comment-13049752 ] 

Dejan Bosanac edited comment on AMQ-3135 at 6/15/11 12:47 PM:
--------------------------------------------------------------

Exactly. But the problem is that connection advisories are not the good tool for getting info on broker-to-broker connections, as there are two connections per bridge and in this duplex case it's not easy to set the ip right (as we only know the ip of the remote host we're sending info to).

On the other hand if you use network advisories for broker-to-broker connections, you'll always get the right information. I'll just add remoteIp property to that advisory and your use case should be covered.

      was (Author: dejanb):
    Exactly. But the problem is that connection advisories are not the good tool for getting info on broker-to-broker connections, as there are two connections per bridge and in this duplex case it's not easy to set it right.

On the other hand if you use network advisories for broker-to-broker connections, you'll always get the right information. I'll just add remoteIp property to that advisory and your use case should be covered.
  
> ActiveMQ.Advisory.Connection messages should contain client ip/host
> -------------------------------------------------------------------
>
>                 Key: AMQ-3135
>                 URL: https://issues.apache.org/jira/browse/AMQ-3135
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.4.2
>         Environment: CentOS, OpenJDK 6, ActiveMQ 5.4.2
>            Reporter: R.I.Pienaar
>            Assignee: Dejan Bosanac
>            Priority: Minor
>             Fix For: 5.6.0
>
>
> At present a connection advisory message recieved over stomp looks like:
> "ConnectionInfo": {
>   "commandId": 0,
>   "responseRequired": true,
>   "connectionId": {
>     "value": "ID:monitor1.xx.net-57901-1294599217160-5:10017"
>   },
>   "clientId": "ID:monitor1.xx.net-57901-1294599217160-5:10017",
>   "userName": "",
>   "password": "",
>   "brokerMasterConnector": false,
>   "manageable": false,
>   "clientMaster": true,
>   "faultTolerant": false,
>   "failoverReconnect": false
> }}
> Where monitor1.xx.net is the broker name.
> It would be very useful if these messages also included the IP Address, Hostname, Port of the client connecting.
> There other advisories that would also greatly benefit from this like ActiveMQ.Advisory.NetworkBridge
> thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira