You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Ryan Blue (JIRA)" <ji...@apache.org> on 2015/02/05 19:19:34 UTC

[jira] [Commented] (PARQUET-178) META-INF for slf4j should not be in parquet-format jar

    [ https://issues.apache.org/jira/browse/PARQUET-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307688#comment-14307688 ] 

Ryan Blue commented on PARQUET-178:
-----------------------------------

Hi [~koert], I have a PR to remove the LICENSE and NOTICE for SLF4J (these are covered by the project's LICENSE and NOTICE files), [#19|https://github.com/apache/incubator-parquet-format/pull/19]. I don't see a problem with these files though, since they contain some useful information about the SLF4J version that was used to build parquet-format. Is this causing a problem? I just want to understand the reasoning behind removing them: should we be removing all META-INF directories when we shade?

> META-INF for slf4j should not be in parquet-format jar
> ------------------------------------------------------
>
>                 Key: PARQUET-178
>                 URL: https://issues.apache.org/jira/browse/PARQUET-178
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-format
>    Affects Versions: 1.6.0rc2
>            Reporter: koert kuipers
>            Priority: Minor
>
> {noformat}
> $ jar tf parquet-format-2.2.0-rc1.jar  | grep org\\.slf
> META-INF/maven/org.slf4j/
> META-INF/maven/org.slf4j/slf4j-api/
> META-INF/maven/org.slf4j/slf4j-api/pom.xml
> META-INF/maven/org.slf4j/slf4j-api/pom.properties
> {noformat}
> It is not clear to me why these are here. I suspect they should not be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)