You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/04/07 23:47:00 UTC
Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
-----------------------------------------------------------
Review request for Ambari, Jayush Luniya and Sumit Mohanty.
Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696
Repository: ambari
Description
-------
The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac060
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 77d5bf89db
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
Diff: https://reviews.apache.org/r/58277/diff/1/
Testing
-------
Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
Python unit tests
Java unit tests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On April 11, 2017, 10:09 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49>
> >
> > Please create a follow-up Jira to set this to False.
> > I'm ok if this is a temporary patch to unblock some testing.
I have created a follow-up jira and will work on any regressions that might cause the defaults as false.
> On April 11, 2017, 10:09 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 102 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686586#file1686586line102>
> >
> > Perhaps check that code is 0 and file length is non-zero before getting file contents.
There is a follow up check-
if code != 0 or out is None:
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171639
-----------------------------------------------------------
On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171639
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 49 (patched)
<https://reviews.apache.org/r/58277/#comment244618>
Please create a follow-up Jira to set this to False.
I'm ok if this is a temporary patch to unblock some testing.
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
Lines 102 (patched)
<https://reviews.apache.org/r/58277/#comment244612>
Perhaps check that code is 0 and file length is non-zero before getting file contents.
- Alejandro Fernandez
On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 9:50 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/2/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On April 11, 2017, 10:14 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 45 (patched)
> > <https://reviews.apache.org/r/58277/diff/2/?file=1689362#file1689362line45>
> >
> > Can this be None as opposed to the String "None"
+1 yes this needs to be None :)
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171643
-----------------------------------------------------------
On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 9:50 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/2/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171643
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 45 (patched)
<https://reviews.apache.org/r/58277/#comment244619>
Can this be None as opposed to the String "None"
- Alejandro Fernandez
On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 9:50 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/2/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171649
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
Lines 438 (patched)
<https://reviews.apache.org/r/58277/#comment244634>
You need to ensure that all code paths pass down the versionAdvertised flag.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
Lines 446 (patched)
<https://reviews.apache.org/r/58277/#comment244633>
add space after ","
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
Lines 1314 (patched)
<https://reviews.apache.org/r/58277/#comment244635>
Space after ","
- Jayush Luniya
On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 9:50 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/2/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171648
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 127 (patched)
<https://reviews.apache.org/r/58277/#comment244632>
The assumption here is that get_stack_tool does not return a stack_selector_path only if versionAdvertised=False which is not true. This warning message should be generic and instead in get_stack_tool you should log the message that cannot return the stack selector tool since versionAdvertised=False.
- Jayush Luniya
On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 9:50 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/2/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On April 11, 2017, 10:29 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> > Lines 421 (patched)
> > <https://reviews.apache.org/r/58277/diff/2/?file=1689364#file1689364line421>
> >
> > Are we using this constant anywhere?
No, removed it.
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171651
-----------------------------------------------------------
On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171651
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
Lines 421 (patched)
<https://reviews.apache.org/r/58277/#comment244637>
Are we using this constant anywhere?
- Jayush Luniya
On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 9:50 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/2/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171800
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Line 120 (original), 120 (patched)
<https://reviews.apache.org/r/58277/#comment244802>
This change has been reverted and hence we no longer need to include it in the patch
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
Line 89 (original), 89 (patched)
<https://reviews.apache.org/r/58277/#comment244803>
This change has been reverted and hence we no longer need to include it in the patch
- Jayush Luniya
On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171808
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On April 12, 2017, 9:55 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:55 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/6/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 12.457 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.034 s]
> [INFO] Ambari Web ......................................... SUCCESS [03:22 min]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.167 s]
> [INFO] Ambari Admin View .................................. SUCCESS [ 8.811 s]
> [INFO] utility ............................................ SUCCESS [ 1.172 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 0.557 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 3.959 s]
> [INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [ 5.448 s]
> [INFO] Ambari Metrics Flume Sink .......................... SUCCESS [ 3.951 s]
> [INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [ 3.229 s]
> [INFO] Ambari Metrics Storm Sink .......................... SUCCESS [ 1.459 s]
> [INFO] Ambari Metrics Storm Sink (Legacy) ................. SUCCESS [ 1.430 s]
> [INFO] Ambari Metrics Collector ........................... SUCCESS [05:27 min]
> [INFO] Ambari Metrics Monitor ............................. SUCCESS [ 4.367 s]
> [INFO] Ambari Metrics Grafana ............................. SUCCESS [ 9.257 s]
> [INFO] Ambari Metrics Assembly ............................ SUCCESS [01:21 min]
> [INFO] Ambari Server ...................................... SUCCESS [29:32 min]
> [INFO] Ambari Functional Tests ............................ SUCCESS [ 2.179 s]
> [INFO] Ambari Agent ....................................... SUCCESS [ 33.694 s]
> [INFO] Ambari Client ...................................... SUCCESS [ 0.031 s]
> [INFO] Ambari Python Client ............................... SUCCESS [ 0.379 s]
> [INFO] Ambari Groovy Client ............................... SUCCESS [ 6.721 s]
> [INFO] Ambari Shell ....................................... SUCCESS [ 0.020 s]
> [INFO] Ambari Python Shell ................................ SUCCESS [ 0.033 s]
> [INFO] Ambari Groovy Shell ................................ SUCCESS [ 4.296 s]
> [INFO] ambari-logsearch ................................... SUCCESS [ 0.141 s]
> [INFO] Ambari Logsearch Appender .......................... SUCCESS [ 0.143 s]
> [INFO] Ambari Logsearch Web ............................... SUCCESS [ 36.382 s]
> [INFO] Ambari Logsearch Server ............................ SUCCESS [ 10.359 s]
> [INFO] Ambari Logsearch Log Feeder ........................ SUCCESS [ 11.536 s]
> [INFO] Ambari Logsearch Assembly .......................... SUCCESS [ 0.133 s]
> [INFO] Ambari Logsearch Integration Test .................. SUCCESS [ 0.360 s]
> [INFO] ambari-infra ....................................... SUCCESS [ 0.022 s]
> [INFO] Ambari Infra Solr Client ........................... SUCCESS [ 1.993 s]
> [INFO] Ambari Infra Solr Plugin ........................... SUCCESS [ 1.242 s]
> [INFO] Ambari Infra Solr Assembly ......................... SUCCESS [ 0.038 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 42:32 min
> [INFO] Finished at: 2017-04-12T12:33:21-07:00
> [INFO] Final Memory: 195M/1632M
> [INFO] ------------------------------------------------------------------------
> $ mvn clean test
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
-----------------------------------------------------------
(Updated April 12, 2017, 9:55 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696
Repository: ambari
Description
-------
The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
Diff: https://reviews.apache.org/r/58277/diff/6/
Testing (updated)
-------
Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
Python unit tests
Java unit tests
[INFO]
[INFO] Ambari Main ........................................ SUCCESS [ 12.457 s]
[INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.034 s]
[INFO] Ambari Web ......................................... SUCCESS [03:22 min]
[INFO] Ambari Views ....................................... SUCCESS [ 2.167 s]
[INFO] Ambari Admin View .................................. SUCCESS [ 8.811 s]
[INFO] utility ............................................ SUCCESS [ 1.172 s]
[INFO] ambari-metrics ..................................... SUCCESS [ 0.557 s]
[INFO] Ambari Metrics Common .............................. SUCCESS [ 3.959 s]
[INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [ 5.448 s]
[INFO] Ambari Metrics Flume Sink .......................... SUCCESS [ 3.951 s]
[INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [ 3.229 s]
[INFO] Ambari Metrics Storm Sink .......................... SUCCESS [ 1.459 s]
[INFO] Ambari Metrics Storm Sink (Legacy) ................. SUCCESS [ 1.430 s]
[INFO] Ambari Metrics Collector ........................... SUCCESS [05:27 min]
[INFO] Ambari Metrics Monitor ............................. SUCCESS [ 4.367 s]
[INFO] Ambari Metrics Grafana ............................. SUCCESS [ 9.257 s]
[INFO] Ambari Metrics Assembly ............................ SUCCESS [01:21 min]
[INFO] Ambari Server ...................................... SUCCESS [29:32 min]
[INFO] Ambari Functional Tests ............................ SUCCESS [ 2.179 s]
[INFO] Ambari Agent ....................................... SUCCESS [ 33.694 s]
[INFO] Ambari Client ...................................... SUCCESS [ 0.031 s]
[INFO] Ambari Python Client ............................... SUCCESS [ 0.379 s]
[INFO] Ambari Groovy Client ............................... SUCCESS [ 6.721 s]
[INFO] Ambari Shell ....................................... SUCCESS [ 0.020 s]
[INFO] Ambari Python Shell ................................ SUCCESS [ 0.033 s]
[INFO] Ambari Groovy Shell ................................ SUCCESS [ 4.296 s]
[INFO] ambari-logsearch ................................... SUCCESS [ 0.141 s]
[INFO] Ambari Logsearch Appender .......................... SUCCESS [ 0.143 s]
[INFO] Ambari Logsearch Web ............................... SUCCESS [ 36.382 s]
[INFO] Ambari Logsearch Server ............................ SUCCESS [ 10.359 s]
[INFO] Ambari Logsearch Log Feeder ........................ SUCCESS [ 11.536 s]
[INFO] Ambari Logsearch Assembly .......................... SUCCESS [ 0.133 s]
[INFO] Ambari Logsearch Integration Test .................. SUCCESS [ 0.360 s]
[INFO] ambari-infra ....................................... SUCCESS [ 0.022 s]
[INFO] Ambari Infra Solr Client ........................... SUCCESS [ 1.993 s]
[INFO] Ambari Infra Solr Plugin ........................... SUCCESS [ 1.242 s]
[INFO] Ambari Infra Solr Assembly ......................... SUCCESS [ 0.038 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 42:32 min
[INFO] Finished at: 2017-04-12T12:33:21-07:00
[INFO] Final Memory: 195M/1632M
[INFO] ------------------------------------------------------------------------
$ mvn clean test
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
-----------------------------------------------------------
(Updated April 12, 2017, 9:55 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
Changes
-------
Review comments - add check for service_name. remove hive_env.xml fixes
Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696
Repository: ambari
Description
-------
The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
Diff: https://reviews.apache.org/r/58277/diff/6/
Changes: https://reviews.apache.org/r/58277/diff/5-6/
Testing
-------
Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
Python unit tests
Java unit tests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171794
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 52 (patched)
<https://reviews.apache.org/r/58277/#comment244795>
We should not look at versionAdvertised flag if service name or role is null. For instance for custom actions like install_packages the command is not specific to a service component and hence we should not skip calling stack/conf selector.
- Jayush Luniya
On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On April 12, 2017, 3:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/58277/diff/5/?file=1691001#file1691001line82>
> >
> > I don't see this being used anywhere.
>
> Madhuvanthi Radhakrishnan wrote:
> It is used in ~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
> stack_version_buildnum = get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")
If that's the only spot using it, then it should be moved into that mpack, no? Otherwsie you risk it being removed in the future and breaking the mpack.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
-----------------------------------------------------------
On April 12, 2017, 2:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 2:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On April 12, 2017, 7:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/58277/diff/5/?file=1691001#file1691001line82>
> >
> > I don't see this being used anywhere.
>
> Madhuvanthi Radhakrishnan wrote:
> It is used in ~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
> stack_version_buildnum = get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")
>
> Jonathan Hurley wrote:
> If that's the only spot using it, then it should be moved into that mpack, no? Otherwsie you risk it being removed in the future and breaking the mpack.
More than one services can use this function (NIFI, STREAMLINE, REGISTRY) and dont have a way to have a shared library within mpack. We can just document the function that this function can be called by custom services and hence not to remove.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
-----------------------------------------------------------
On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On April 12, 2017, 7:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/58277/diff/5/?file=1691001#file1691001line82>
> >
> > I don't see this being used anywhere.
It is used in ~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
stack_version_buildnum = get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
-----------------------------------------------------------
On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
Lines 82 (patched)
<https://reviews.apache.org/r/58277/#comment244782>
I don't see this being used anywhere.
- Jonathan Hurley
On April 12, 2017, 2:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 2:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
-----------------------------------------------------------
(Updated April 12, 2017, 6:04 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
Changes
-------
Review comments incorporated - python variable name, string formatting.
Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696
Repository: ambari
Description
-------
The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
Diff: https://reviews.apache.org/r/58277/diff/5/
Changes: https://reviews.apache.org/r/58277/diff/4-5/
Testing
-------
Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
Python unit tests
Java unit tests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171732
-----------------------------------------------------------
Fix it, then Ship it!
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 48-49 (patched)
<https://reviews.apache.org/r/58277/#comment244749>
This appears to be relying on the server sending the value properly, if at all. May be safer to assume False. If it defaults true and the stack selector isn't actually available you may be in a bad code path.
Also, we tend to use an underscore format for python variables rather than a camel-case.
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
Lines 107-108 (patched)
<https://reviews.apache.org/r/58277/#comment244750>
%s format is deprecated. Use {0} notation.
- Nate Cole
On April 12, 2017, 2:15 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 2:15 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/4/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
-----------------------------------------------------------
(Updated April 12, 2017, 6:15 a.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
Changes
-------
ServicePropertiesTest was failing due to a recent patch - https://reviews.apache.org/r/57687/diff/2#index_header, fixed that in hive-env.xml
Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696
Repository: ambari
Description
-------
The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
Diff: https://reviews.apache.org/r/58277/diff/4/
Changes: https://reviews.apache.org/r/58277/diff/3-4/
Testing
-------
Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
Python unit tests
Java unit tests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
-----------------------------------------------------------
(Updated April 12, 2017, 4:54 a.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
Changes
-------
Incorporated Review comments
Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696
Repository: ambari
Description
-------
The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
Diff: https://reviews.apache.org/r/58277/diff/3/
Changes: https://reviews.apache.org/r/58277/diff/2-3/
Testing
-------
Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
Python unit tests
Java unit tests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
-----------------------------------------------------------
(Updated April 11, 2017, 9:50 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
Changes
-------
Incorporated review comments
Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696
Repository: ambari
Description
-------
The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
Diff: https://reviews.apache.org/r/58277/diff/2/
Changes: https://reviews.apache.org/r/58277/diff/1-2/
Testing
-------
Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
Python unit tests
Java unit tests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49>
> >
> > This should actually be False by default.
>
> Jayush Luniya wrote:
> Technically yes default should be False. However we have to ensure that there are no regressions if versionAdvertised is not passed in some code path in the command.json. Using versionAdvertised=True ensures that we are not regressing the past behavior.
>
> Alejandro Fernandez wrote:
> Default in metainfo.xml is False. We should maintain that consistency in EU/RU, at least for now, especially since this may impact custom services.
@Alejandro,
Madhu will file a follow up JIRA for setting the versionAdvertised=False by default, there are few code paths and tests required to be updated for it to work correctly. However this patch is critical for unblocking work for HDP + Nifi custom service installation.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
-----------------------------------------------------------
On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 11:47 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac060
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 77d5bf89db
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/1/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49>
> >
> > This should actually be False by default.
>
> Jayush Luniya wrote:
> Technically yes default should be False. However we have to ensure that there are no regressions if versionAdvertised is not passed in some code path in the command.json. Using versionAdvertised=True ensures that we are not regressing the past behavior.
Default in metainfo.xml is False. We should maintain that consistency in EU/RU, at least for now, especially since this may impact custom services.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
-----------------------------------------------------------
On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 11:47 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac060
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 77d5bf89db
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/1/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 219 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686583#file1686583line219>
> >
> > We should not hardcode any stack name or path.
> > If HDP stack needs to use "/usr/hdf", then consider passing a variable to this function to overwrite the default stack_root.
> >
> > Even in traditional HDP stacks, /usr/hdf will not exist.
Madhu, we can handle the RANGER changes in a separate JIRA and let RANGER team drive that change. I also see some deadcode that needs to be removed.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
-----------------------------------------------------------
On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 11:47 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac060
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 77d5bf89db
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/1/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 219 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686583#file1686583line219>
> >
> > We should not hardcode any stack name or path.
> > If HDP stack needs to use "/usr/hdf", then consider passing a variable to this function to overwrite the default stack_root.
> >
> > Even in traditional HDP stacks, /usr/hdf will not exist.
>
> Jayush Luniya wrote:
> Madhu, we can handle the RANGER changes in a separate JIRA and let RANGER team drive that change. I also see some deadcode that needs to be removed.
Removed this file from the list of changes
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 87 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686586#file1686586line87>
> >
> > If any are missing, throw an error.
> > Right now, this will pass if stay stack_selector_path is non null but component_name is null
Hi Alejandro,
The existing code checks for component_name argument too.
if not stack_selector_path:
Logger.error("Stack selector path not provided")
elif not os.path.exists(stack_selector_path):
Logger.error("Stack selector path does not exist")
elif not component_name:
Logger.error("Component name not provided")
else:
tmpfile = tempfile.NamedTemporaryFile()
...
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
-----------------------------------------------------------
On April 12, 2017, 4:54 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 4:54 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/3/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49>
> >
> > This should actually be False by default.
Technically yes default should be False. However we have to ensure that there are no regressions if versionAdvertised is not passed in some code path in the command.json. Using versionAdvertised=True ensures that we are not regressing the past behavior.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
-----------------------------------------------------------
On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 11:47 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac060
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 77d5bf89db
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/1/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector,
conf selector tools for Nifi, Streamline,
Registry custom services in HDP cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
-----------------------------------------------------------
Please also include Nate and Jonathan in the review
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
Lines 219 (patched)
<https://reviews.apache.org/r/58277/#comment244384>
We should not hardcode any stack name or path.
If HDP stack needs to use "/usr/hdf", then consider passing a variable to this function to overwrite the default stack_root.
Even in traditional HDP stacks, /usr/hdf will not exist.
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 127 (patched)
<https://reviews.apache.org/r/58277/#comment244385>
Put quotes around "stack select set all"
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 45 (patched)
<https://reviews.apache.org/r/58277/#comment244386>
We shouldn't default to one stack over the other
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 49 (patched)
<https://reviews.apache.org/r/58277/#comment244387>
This should actually be False by default.
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
Lines 82 (patched)
<https://reviews.apache.org/r/58277/#comment244388>
Add some doc for what the function does.
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
Lines 87 (patched)
<https://reviews.apache.org/r/58277/#comment244389>
If any are missing, throw an error.
Right now, this will pass if stay stack_selector_path is non null but component_name is null
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/58277/#comment244390>
Use named imports
- Alejandro Fernandez
On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 11:47 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac060
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 77d5bf89db
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/1/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>