[GitHub] [linkis] peacewong commented on a diff in pull request #4272: [bugfix] when executor is shutdown, the status is complete that send to linkimanager

["peacewong (via GitHub)" <gi...@apache.org>]

peacewong commented on code in PR #4272:
URL: https://github.com/apache/linkis/pull/4272#discussion_r1118104267


##########
linkis-computation-governance/linkis-engineconn/linkis-engineconn-executor/accessible-executor/src/main/scala/org/apache/linkis/engineconn/acessible/executor/service/DefaultAccessibleService.scala:
##########
@@ -92,15 +92,12 @@ class DefaultAccessibleService extends AccessibleService with Logging {
       return
     }
     var executor: Executor = ExecutorManager.getInstance.getReportExecutor
-    if (null != executor) {
-      Utils.tryAndWarn {
-        executor.close()
-        executor.tryShutdown()
-      }
-      logger.warn(s"Engine : ${Sender.getThisInstance} with state has stopped successfully.")
-    } else {
+    if (null == executor) {
       executor = SensibleExecutor.getDefaultErrorSensibleExecutor
     }
+    Utils.tryAndWarn(executor.tryShutdown())

Review Comment:
   Thank you, is it because ReportExecutor is null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org