[GitHub] [hbase] Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests in TestFromClientSide

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests in TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#discussion_r306101357
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
 ##########
 @@ -1156,20 +1156,28 @@ public void testSingleRowMultipleFamily() throws Exception {
   }
 
   @Test
-  public void testNull() throws Exception {
-    final TableName tableName = TableName.valueOf(name.getMethodName());
-
+  public void testNullTableName() {
     // Null table name (should NOT work)
     try {
       TEST_UTIL.createTable((TableName)null, FAMILY);
       fail("Creating a table with null name passed, should have failed");
     } catch(Exception e) {}
 
 Review comment:
   Since we have split the method, we can use the @Test(expected = XXXException.class) so we do not need to catch the exception any more?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services