You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/10 09:00:34 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request #14211: [Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException
liangyepianzhou opened a new pull request #14211:
URL: https://github.com/apache/pulsar/pull/14211
Master https://github.com/apache/pulsar/issues/13918
### Motivation & Modification
Makes exceptions on the Transaction client side clearer.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14211: [Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14211:
URL: https://github.com/apache/pulsar/pull/14211#issuecomment-1072916799
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #14211: [Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on pull request #14211:
URL: https://github.com/apache/pulsar/pull/14211#issuecomment-1034947063
> MetaStoreHandlerNotReadyException
> PulsarClientException
Just my personal opinion
1. We will eventually delete this `TransactionCoordinatorClientException`, so we need to remove this exception from it
2. This exception is caused by that pulsarClient perform ops related to transaction when `MetaStoreHandler` was not in the right state that can sent request to TC. So put it into PulsarClientException is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a change in pull request #14211: [Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on a change in pull request #14211:
URL: https://github.com/apache/pulsar/pull/14211#discussion_r804284173
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionClientConnectTest.java
##########
@@ -156,8 +157,7 @@ public void testPulsarClientCloseThenCloseTcClient() throws Exception {
try {
handler.newTransactionAsync(10, TimeUnit.SECONDS).get();
Review comment:
Maybe we need to add ``fail()`` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #14211: [Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on pull request #14211:
URL: https://github.com/apache/pulsar/pull/14211#issuecomment-1034951715
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #14211: [Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #14211:
URL: https://github.com/apache/pulsar/pull/14211#issuecomment-1034731689
Sorry, I'm not sure why we need to make the exception `MetaStoreHandlerNotReadyException` to extend `PulsarClientException`. Could you add some explanation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org