You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "anshul98ks123 (via GitHub)" <gi...@apache.org> on 2025/06/24 18:44:28 UTC
[PR] [index] Fix legacy deserializers for Dictionary and JSON indexes [pinot]
anshul98ks123 opened a new pull request, #16191:
URL: https://github.com/apache/pinot/pull/16191
## Issue
[createTableConfigFromOldFormat](https://github.com/startreedata/pinot/blob/5d7fab1cc3177ce21fa2da1e1287f17c461c7df3/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java#L1449) util method fails for a valid tableConfig
## Description
In a [recent change](https://github.com/startreedata/pinot/commit/c96c318ef8b9897b04d6f4afe709b1f09fd33cec#diff-ac7ba46a862780f8f703c30869b17418a6d3e6f729e507b18044933a24588438L31-L44), logic for [creating deserializers](https://github.com/startreedata/pinot/blob/5d7fab1cc3177ce21fa2da1e1287f17c461c7df3/pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/AbstractIndexType.java#L45) for all IndexTypes was changed to
```
protected ColumnConfigDeserializer<C> createDeserializer() {
ColumnConfigDeserializer<C> fromIndexes =
IndexConfigDeserializer.fromIndexes(getPrettyName(), getIndexConfigClass());
ColumnConfigDeserializer<C> fromLegacyConfigs = createDeserializerForLegacyConfigs();
return fromLegacyConfigs != null ? fromIndexes.withExclusiveAlternative(fromLegacyConfigs) : fromIndexes;
}
```
This creates two deserializers:
1. one for indexes in new format
2. one for legacy format
and combined desirealizer has `FAIL` _onConfict_ property, so if both the deserializers detect the same config, it'll result in error like following:
```
Configuration is declared in two different ways for index dictionary on column address
```
example valid table config for which it fails:
[example_table_config.json](https://github.com/user-attachments/files/20887301/example_table_config.json)
```
{
"tableConfig": {
"tableIndexConfig": {
...
"varLengthDictionaryColumns": null
...
},
...
"fieldConfigList": [
...
{
"name": "address",
"encodingType": "RAW",
"indexTypes": [],
"indexes": {
"dictionary": {
"disabled": false,
"onHeap": false,
"useVarLengthDictionary": true
},
"inverted": {
"disabled": false
}
},
"tierOverwrites": null
}
...
]
...
},
"schema": {
...
}
}
```
The logic of `createDeserializerForLegacyConfigs()`
for Dictionary index and Json index reads from new format as well,
which is incorrect and leads to above mentioned issue
Legacy deserializer logic should not infer indexes from new format now
This PR fixes that
It also adds missing json initializer for VectorIndexConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "anshul98ks123 (via GitHub)" <gi...@apache.org>.
anshul98ks123 commented on PR #16191:
URL: https://github.com/apache/pinot/pull/16191#issuecomment-3001824698
Alright, i'll try to add some test cases for this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #16191:
URL: https://github.com/apache/pinot/pull/16191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "anshul98ks123 (via GitHub)" <gi...@apache.org>.
anshul98ks123 commented on PR #16191:
URL: https://github.com/apache/pinot/pull/16191#issuecomment-3001739697
I feel the logic for
[createTableConfigFromOldFormat](https://github.com/apache/pinot/blob/b62b9e66830731f2221cffa292c907aac146d849/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java#L1449)
also seems bit incorrect
do we even have a new format for vectorindexconfig?
because this util method moves configuration to indexes key
but doesn't cleanup the old way of defining in indexTypes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "anshul98ks123 (via GitHub)" <gi...@apache.org>.
anshul98ks123 commented on PR #16191:
URL: https://github.com/apache/pinot/pull/16191#issuecomment-3001794980
it's similar to H3 Index
https://docs.pinot.apache.org/basics/indexing/geospatial-support#how-to-use-geoindex
for that as well, i see structure is similar
in old, we use indexType and properties
in new, we use the indexes
so we should be cleaning fieldConfig.properties as well along with indexes after moving to new format
```
"fieldConfigList": [
{
"name": "studentID",
"encodingType": "DICTIONARY",
"indexTypes": [],
"indexes": {
"vector": {
"version": 1,
"properties": {
"vectorIndexType": "HNSW",
"vectorDimension": "1536",
"vectorDistanceFunction": "COSINE",
"version": "1"
},
"vectorDistanceFunction": "COSINE",
"vectorIndexType": "HNSW",
"vectorDimension": 1536,
"disabled": false
}
},
"properties": null,
"tierOverwrites": null
}
],
```
just pushed a commit to do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "anshul98ks123 (via GitHub)" <gi...@apache.org>.
anshul98ks123 commented on code in PR #16191:
URL: https://github.com/apache/pinot/pull/16191#discussion_r2164987240
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/creator/VectorIndexConfig.java:
##########
@@ -68,6 +70,21 @@ public VectorIndexConfig(@Nullable Map<String, String> properties) {
_properties = properties;
}
+ @JsonCreator
+ public VectorIndexConfig(@JsonProperty("disabled") Boolean disabled,
Review Comment:
done
##########
pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/VectorConfigTest.java:
##########
@@ -0,0 +1,127 @@
+package org.apache.pinot.segment.spi.index;
Review Comment:
done
,
##########
pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/VectorConfigTest.java:
##########
@@ -0,0 +1,127 @@
+package org.apache.pinot.segment.spi.index;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "anshul98ks123 (via GitHub)" <gi...@apache.org>.
anshul98ks123 commented on PR #16191:
URL: https://github.com/apache/pinot/pull/16191#issuecomment-3001894634
Added UTs for VectorIndexConfig (similar to [H3ConfigTest](https://github.com/startreedata/pinot/blob/5d7fab1cc3177ce21fa2da1e1287f17c461c7df3/pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/creator/H3IndexConfigTest.java#L31))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "anshul98ks123 (via GitHub)" <gi...@apache.org>.
anshul98ks123 commented on code in PR #16191:
URL: https://github.com/apache/pinot/pull/16191#discussion_r2164877344
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/creator/VectorIndexConfig.java:
##########
@@ -68,6 +70,21 @@ public VectorIndexConfig(@Nullable Map<String, String> properties) {
_properties = properties;
}
+ @JsonCreator
+ public VectorIndexConfig(@JsonProperty("disabled") Boolean disabled,
+ @JsonProperty("vectorIndexType") @Nullable String vectorIndexType,
+ @JsonProperty("vectorDimension") @Nullable int vectorDimension,
+ @JsonProperty("version") @Nullable int version,
Review Comment:
ahh, right
thanks for pointing out. fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #16191:
URL: https://github.com/apache/pinot/pull/16191#discussion_r2164969375
##########
pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/VectorConfigTest.java:
##########
@@ -0,0 +1,127 @@
+package org.apache.pinot.segment.spi.index;
Review Comment:
Add license header
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/creator/VectorIndexConfig.java:
##########
@@ -68,6 +70,21 @@ public VectorIndexConfig(@Nullable Map<String, String> properties) {
_properties = properties;
}
+ @JsonCreator
+ public VectorIndexConfig(@JsonProperty("disabled") Boolean disabled,
Review Comment:
(minor) `disabled` is `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "anshul98ks123 (via GitHub)" <gi...@apache.org>.
anshul98ks123 commented on PR #16191:
URL: https://github.com/apache/pinot/pull/16191#issuecomment-3001996938
Added few more tests
for old to new format conversion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #16191:
URL: https://github.com/apache/pinot/pull/16191#issuecomment-3001820593
Consider adding a test for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #16191:
URL: https://github.com/apache/pinot/pull/16191#discussion_r2164873913
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/creator/VectorIndexConfig.java:
##########
@@ -68,6 +70,21 @@ public VectorIndexConfig(@Nullable Map<String, String> properties) {
_properties = properties;
}
+ @JsonCreator
+ public VectorIndexConfig(@JsonProperty("disabled") Boolean disabled,
+ @JsonProperty("vectorIndexType") @Nullable String vectorIndexType,
+ @JsonProperty("vectorDimension") @Nullable int vectorDimension,
+ @JsonProperty("version") @Nullable int version,
Review Comment:
Primitive type cannot be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16191:
URL: https://github.com/apache/pinot/pull/16191#issuecomment-3002194921
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/16191?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `22.22222%` with `7 lines` in your changes missing coverage. Please review.
> Project coverage is 33.36%. Comparing base [(`1a476de`)](https://app.codecov.io/gh/apache/pinot/commit/1a476dea72ebf1c15e14ded28ae60c385f71b2c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`afad289`)](https://app.codecov.io/gh/apache/pinot/commit/afad289545bdb526325f776209f8ec7a319d0ba4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 334 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/16191?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...t/segment/spi/index/creator/VectorIndexConfig.java](https://app.codecov.io/gh/apache/pinot/pull/16191?src=pr&el=tree&filepath=pinot-segment-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Fspi%2Findex%2Fcreator%2FVectorIndexConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L2NyZWF0b3IvVmVjdG9ySW5kZXhDb25maWcuamF2YQ==) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1a476de) and HEAD (afad289). Click for more details.
>
> <details><summary>HEAD has 68 uploads less than BASE</summary>
>
>| Flag | BASE (1a476de) | HEAD (afad289) |
>|------|------|------|
>|java-21|10|1|
>|unittests|6|1|
>|unittests1|3|0|
>|skip-bytebuffers-true|4|0|
>|temurin|15|1|
>|unittests2|3|1|
>|skip-bytebuffers-false|8|0|
>|java-11|5|0|
>|integration|9|0|
>|integration2|3|0|
>|integration1|3|0|
>|custom-integration1|3|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16191 +/- ##
=============================================
- Coverage 62.90% 33.36% -29.54%
+ Complexity 1386 659 -727
=============================================
Files 2867 2953 +86
Lines 163354 170243 +6889
Branches 24952 26045 +1093
=============================================
- Hits 102755 56805 -45950
- Misses 52847 108872 +56025
+ Partials 7752 4566 -3186
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.36% <22.22%> (-29.46%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.36% <22.22%> (-29.54%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.36% <22.22%> (-29.54%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/16191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.36% <22.22%> (-0.21%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/16191?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [index] Add json creator initializer for VectorIndexConfig [pinot]
Posted by "anshul98ks123 (via GitHub)" <gi...@apache.org>.
anshul98ks123 commented on PR #16191:
URL: https://github.com/apache/pinot/pull/16191#issuecomment-3002217837
Strange! One UT CI failed
Failing tests seem unrelated
https://github.com/apache/pinot/actions/runs/15862860321/job/44725443154?pr=16191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org