You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2020/05/04 14:25:10 UTC

Re: Ianal Maven Plugin?

Got it. But did you stumble upon an actual problem with the plug-in, or
is the problem that plug-in is old and unmaintained?

Thanks,
Robert

On Thu, 2020-04-30 at 09:50 -0700, Andreas Schaefer wrote:
> I wanted to create a Feature Archive using the Slingfeature Maven
> plugin and using the Sling POM (38).
> The build failed because of the IANAL checks. While trying to find a
> solution I noticed that this is old plugin, w/o code, docs and still
> in alpha which raised a red flag.
> 
> Cheers - Andy 
> 
> > On Apr 30, 2020, at 4:09 AM, Robert Munteanu <ro...@apache.org>
> > wrote:
> > 
> > On Thu, 2020-04-30 at 11:58 +0200, Konrad Windszus wrote:
> > > It is still listed here: https://www.mojohaus.org/plugins.html <
> > > https://www.mojohaus.org/plugins.html> but was not (yet) moved to
> > > Github nor is any documentation available at the www.mojohaus.org
> > >  <
> > > http://www.mojohaus.org/>
> > > Maybe some of the alternatives listed in 
> > > http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html
> > > <
> > > http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html
> > > > would work for us...
> > 
> > We cloud also ask mojohaus to move the plugin to GitHub and propose
> > a
> > fix.
> > 
> > Andy, what exact problem did you encounter with the plug-in?
> > 
> > Thanks,
> > Robert
> > 
> > > Konrad
> > > 
> > > > On 30. Apr 2020, at 11:05, Robert Munteanu <ro...@apache.org>
> > > > wrote:
> > > > 
> > > > On Thu, 2020-04-30 at 10:06 +0200, Carsten Ziegeler wrote:
> > > > > As far as I remember, it checks that the artifacts (jars)
> > > > > have
> > > > > the 
> > > > > required legal files, LICENSE and NOTICE.
> > > > > But given that this plugin is totally outdated, its probably
> > > > > safer
> > > > > to 
> > > > > remove it
> > > > 
> > > > It would be good to still check for the legal files though.
> > > > 
> > > > Robert
> > > > 
> > > > > Regards
> > > > > Carsten
> > > > > 
> > > > > On 30.04.2020 09:58, Stefan Seifert wrote:
> > > > > > +1 to remove it
> > > > > > 
> > > > > > it seems the plugin was already present in the very first
> > > > > > commit
> > > > > > 2009 "move sling to new TLP" location.
> > > > > > i've no idea what it does.
> > > > > > 
> > > > > > stefan
> > > > > > 
> > > > > > > -----Original Message-----
> > > > > > > From: Andreas Schaefer <sc...@me.com.INVALID>
> > > > > > > Sent: Thursday, April 30, 2020 1:12 AM
> > > > > > > To: dev <de...@sling.apache.org>
> > > > > > > Subject: Ianal Maven Plugin?
> > > > > > > 
> > > > > > > Hi
> > > > > > > 
> > > > > > > I just stumbled over an issue with Ianal Maven Plugin and
> > > > > > > when I
> > > > > > > wanted to
> > > > > > > see what it is looking for I discovered that the project
> > > > > > > does
> > > > > > > not
> > > > > > > exist
> > > > > > > anymore nor does a documentation page.
> > > > > > > The plugin was released 2008 as alpha and nothing since.
> > > > > > > 
> > > > > > > Shouldn’t we stop using that plugin or find / create a
> > > > > > > replacement for it?
> > > > > > > 
> > > > > > > Cheers - Andy


Re: Ianal Maven Plugin?

Posted by Robert Munteanu <ro...@apache.org>.
On Thu, 2021-01-07 at 14:46 +0100, Robert Munteanu wrote:
> I would suggest that we try the Geronimo plugin first.

A bit later, I decided to actually create a PR for it

  https://github.com/apache/sling-parent/pull/21

If no one complains, this will be in parent 46.

Thanks,
Robert


Re: Ianal Maven Plugin?

Posted by Robert Munteanu <ro...@apache.org>.
Hi Konrad,

On Sun, 2020-12-27 at 13:08 +0100, Konrad Windszus wrote:
> I propose to no longer activate the plugin by default. It currently
> checks for existence of both LICENSE and NOTICE files in all attached
> artifacts.
> 
> For JAR artifacts this is not necessary:
> For NOTICE this is always done via the sling-parent pom.xml (
> https://github.com/apache/sling-parent/blob/525ef3128cccc22c39624229158375104a131849/sling-parent/pom.xml#L182
>  <
> https://github.com/apache/sling-parent/blob/525ef3128cccc22c39624229158375104a131849/sling-parent/pom.xml#L182
> >)
> For LICENSE we can use 
> https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html
>  <
> https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html
> > instead to make sure it always exists on the root level of the
> repository (a check not yet performed by IANAL).
> Its existence is also ensured by 
> https://maven.apache.org/apache-resource-bundles/index.html <
> https://maven.apache.org/apache-resource-bundles/index.html> being
> included in 
> https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L335
>  <
> https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L335
> >.
> 
> For ZIP files we can still use the IANAL plugin, but the parent
> should not longer activate it by default because 90% of our artifacts
> are Jars... Currently activating it leads to WARNINGs with Java 11.

I think that it is worthwhile having some sort of check for the legal
artifacts, even though we should not have this problem.

I would suggest that we try the Geronimo plugin first.

Thanks,
Robert


Re: Ianal Maven Plugin?

Posted by Konrad Windszus <ko...@gmx.de>.
I propose to no longer activate the plugin by default. It currently checks for existence of both LICENSE and NOTICE files in all attached artifacts.

For JAR artifacts this is not necessary:
For NOTICE this is always done via the sling-parent pom.xml (https://github.com/apache/sling-parent/blob/525ef3128cccc22c39624229158375104a131849/sling-parent/pom.xml#L182 <https://github.com/apache/sling-parent/blob/525ef3128cccc22c39624229158375104a131849/sling-parent/pom.xml#L182>)
For LICENSE we can use https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html <https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html> instead to make sure it always exists on the root level of the repository (a check not yet performed by IANAL).
Its existence is also ensured by https://maven.apache.org/apache-resource-bundles/index.html <https://maven.apache.org/apache-resource-bundles/index.html> being included in https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L335 <https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L335>.

For ZIP files we can still use the IANAL plugin, but the parent should not longer activate it by default because 90% of our artifacts are Jars... Currently activating it leads to WARNINGs with Java 11.

WDYT?
Konrad

> On 5. May 2020, at 20:15, Robert Munteanu <ro...@apache.org> wrote:
> 
> On Tue, 2020-05-05 at 19:11 +0200, Bertrand Delacretaz wrote:
>> On Tue, May 5, 2020 at 6:21 PM Konrad Windszus <ko...@gmx.de>
>> wrote:
>>> ...interesting finding but unfortunately last updated in 2008
>>> ( 
>>> https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plugin
>>> ).
>>> Seems dead as well....
>> 
>> But that's code that already belongs to the ASF, if someone wants to
>> adopt that code in Sling we can get the source code from Maven,
>> notify
>> the Geronimo PMC to be polite and create a small plugin with just the
>> VerifyLegalFilesMojo.java [1], which is not rocket science level code
>> ;-)
> 
> +1
> 
> Robert


Re: Ianal Maven Plugin?

Posted by Robert Munteanu <ro...@apache.org>.
On Tue, 2020-05-05 at 19:11 +0200, Bertrand Delacretaz wrote:
> On Tue, May 5, 2020 at 6:21 PM Konrad Windszus <ko...@gmx.de>
> wrote:
> > ...interesting finding but unfortunately last updated in 2008
> > ( 
> > https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plugin
> > ).
> > Seems dead as well....
> 
> But that's code that already belongs to the ASF, if someone wants to
> adopt that code in Sling we can get the source code from Maven,
> notify
> the Geronimo PMC to be polite and create a small plugin with just the
> VerifyLegalFilesMojo.java [1], which is not rocket science level code
> ;-)

+1

Robert


Re: Ianal Maven Plugin?

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, May 5, 2020 at 6:21 PM Konrad Windszus <ko...@gmx.de> wrote:
> ...interesting finding but unfortunately last updated in 2008
> ( https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plugin).
> Seems dead as well....

But that's code that already belongs to the ASF, if someone wants to
adopt that code in Sling we can get the source code from Maven, notify
the Geronimo PMC to be polite and create a small plugin with just the
VerifyLegalFilesMojo.java [1], which is not rocket science level code
;-)

-Bertrand

[1] https://gist.github.com/bdelacretaz/b1d24fd9d782aa3c31e0e9e91f858c57

Re: Ianal Maven Plugin?

Posted by Konrad Windszus <ko...@gmx.de>.
Hi,
interesting finding but unfortunately last updated in 2008 ( https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plugin). Seems dead as well....

Konrad

> On 5. May 2020, at 17:19, Bertrand Delacretaz <bd...@apache.org> wrote:
> 
> Hi,
> 
> On Tue, May 5, 2020 at 11:23 AM Robert Munteanu <ro...@apache.org> wrote:
>> ...If we would find a way to replace it, it would be even
>> better :-)..
> 
> I stumbled on https://geronimo.apache.org/maven/genesis/plugins/tools-maven-plugin/usage.html
> by chance, which apparently ("verify-legal-file") does check for
> LICENSE and NOTICE files.
> 
> -Bertrand


Re: Ianal Maven Plugin?

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,

On Tue, May 5, 2020 at 11:23 AM Robert Munteanu <ro...@apache.org> wrote:
> ...If we would find a way to replace it, it would be even
> better :-)..

I stumbled on https://geronimo.apache.org/maven/genesis/plugins/tools-maven-plugin/usage.html
by chance, which apparently ("verify-legal-file") does check for
LICENSE and NOTICE files.

-Bertrand

Re: Ianal Maven Plugin?

Posted by Robert Munteanu <ro...@apache.org>.
Ack. Feel free to file an issue against the parent pom so we don't
forget about it. If would find a way to replace it, it would be even
better :-)

Thanks,
Robert

On Mon, 2020-05-04 at 12:01 -0700, Andreas Schaefer wrote:
> I had an issue where the plugin (because I used Sling Parent POM) and
> could not figure out what it needed.
> Then I realized that the plugin was outdated but guessed that when it
> set ’strict’ to false that it would let me process which it did.
> 
> Anyhow I am concerned that eventually this plugin will fail and I
> think we should move away now that when it is not working anymore.
> 
> Cheers - Andy
> 
> > On May 4, 2020, at 7:25 AM, Robert Munteanu <ro...@apache.org>
> > wrote:
> > 
> > Got it. But did you stumble upon an actual problem with the plug-
> > in, or
> > is the problem that plug-in is old and unmaintained?
> > 
> > Thanks,
> > Robert
> > 
> > On Thu, 2020-04-30 at 09:50 -0700, Andreas Schaefer wrote:
> > > I wanted to create a Feature Archive using the Slingfeature Maven
> > > plugin and using the Sling POM (38).
> > > The build failed because of the IANAL checks. While trying to
> > > find a
> > > solution I noticed that this is old plugin, w/o code, docs and
> > > still
> > > in alpha which raised a red flag.
> > > 
> > > Cheers - Andy 
> > > 
> > > > On Apr 30, 2020, at 4:09 AM, Robert Munteanu <
> > > > rombert@apache.org>
> > > > wrote:
> > > > 
> > > > On Thu, 2020-04-30 at 11:58 +0200, Konrad Windszus wrote:
> > > > > It is still listed here: 
> > > > > https://www.mojohaus.org/plugins.html <
> > > > > https://www.mojohaus.org/plugins.html> but was not (yet)
> > > > > moved to
> > > > > Github nor is any documentation available at the 
> > > > > www.mojohaus.org
> > > > > <
> > > > > http://www.mojohaus.org/>
> > > > > Maybe some of the alternatives listed in 
> > > > > http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html
> > > > > <
> > > > > http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html
> > > > > > would work for us...
> > > > 
> > > > We cloud also ask mojohaus to move the plugin to GitHub and
> > > > propose
> > > > a
> > > > fix.
> > > > 
> > > > Andy, what exact problem did you encounter with the plug-in?
> > > > 
> > > > Thanks,
> > > > Robert
> > > > 
> > > > > Konrad
> > > > > 
> > > > > > On 30. Apr 2020, at 11:05, Robert Munteanu <
> > > > > > rombert@apache.org>
> > > > > > wrote:
> > > > > > 
> > > > > > On Thu, 2020-04-30 at 10:06 +0200, Carsten Ziegeler wrote:
> > > > > > > As far as I remember, it checks that the artifacts (jars)
> > > > > > > have
> > > > > > > the 
> > > > > > > required legal files, LICENSE and NOTICE.
> > > > > > > But given that this plugin is totally outdated, its
> > > > > > > probably
> > > > > > > safer
> > > > > > > to 
> > > > > > > remove it
> > > > > > 
> > > > > > It would be good to still check for the legal files though.
> > > > > > 
> > > > > > Robert
> > > > > > 
> > > > > > > Regards
> > > > > > > Carsten
> > > > > > > 
> > > > > > > On 30.04.2020 09:58, Stefan Seifert wrote:
> > > > > > > > +1 to remove it
> > > > > > > > 
> > > > > > > > it seems the plugin was already present in the very
> > > > > > > > first
> > > > > > > > commit
> > > > > > > > 2009 "move sling to new TLP" location.
> > > > > > > > i've no idea what it does.
> > > > > > > > 
> > > > > > > > stefan
> > > > > > > > 
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: Andreas Schaefer <sc...@me.com.INVALID>
> > > > > > > > > Sent: Thursday, April 30, 2020 1:12 AM
> > > > > > > > > To: dev <de...@sling.apache.org>
> > > > > > > > > Subject: Ianal Maven Plugin?
> > > > > > > > > 
> > > > > > > > > Hi
> > > > > > > > > 
> > > > > > > > > I just stumbled over an issue with Ianal Maven Plugin
> > > > > > > > > and
> > > > > > > > > when I
> > > > > > > > > wanted to
> > > > > > > > > see what it is looking for I discovered that the
> > > > > > > > > project
> > > > > > > > > does
> > > > > > > > > not
> > > > > > > > > exist
> > > > > > > > > anymore nor does a documentation page.
> > > > > > > > > The plugin was released 2008 as alpha and nothing
> > > > > > > > > since.
> > > > > > > > > 
> > > > > > > > > Shouldn’t we stop using that plugin or find / create
> > > > > > > > > a
> > > > > > > > > replacement for it?
> > > > > > > > > 
> > > > > > > > > Cheers - Andy


Re: Ianal Maven Plugin?

Posted by Andreas Schaefer <sc...@me.com.INVALID>.
I had an issue where the plugin (because I used Sling Parent POM) and could not figure out what it needed.
Then I realized that the plugin was outdated but guessed that when it set ’strict’ to false that it would let me process which it did.

Anyhow I am concerned that eventually this plugin will fail and I think we should move away now that when it is not working anymore.

Cheers - Andy

> On May 4, 2020, at 7:25 AM, Robert Munteanu <ro...@apache.org> wrote:
> 
> Got it. But did you stumble upon an actual problem with the plug-in, or
> is the problem that plug-in is old and unmaintained?
> 
> Thanks,
> Robert
> 
> On Thu, 2020-04-30 at 09:50 -0700, Andreas Schaefer wrote:
>> I wanted to create a Feature Archive using the Slingfeature Maven
>> plugin and using the Sling POM (38).
>> The build failed because of the IANAL checks. While trying to find a
>> solution I noticed that this is old plugin, w/o code, docs and still
>> in alpha which raised a red flag.
>> 
>> Cheers - Andy 
>> 
>>> On Apr 30, 2020, at 4:09 AM, Robert Munteanu <ro...@apache.org>
>>> wrote:
>>> 
>>> On Thu, 2020-04-30 at 11:58 +0200, Konrad Windszus wrote:
>>>> It is still listed here: https://www.mojohaus.org/plugins.html <
>>>> https://www.mojohaus.org/plugins.html> but was not (yet) moved to
>>>> Github nor is any documentation available at the www.mojohaus.org
>>>> <
>>>> http://www.mojohaus.org/>
>>>> Maybe some of the alternatives listed in 
>>>> http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html
>>>> <
>>>> http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html
>>>>> would work for us...
>>> 
>>> We cloud also ask mojohaus to move the plugin to GitHub and propose
>>> a
>>> fix.
>>> 
>>> Andy, what exact problem did you encounter with the plug-in?
>>> 
>>> Thanks,
>>> Robert
>>> 
>>>> Konrad
>>>> 
>>>>> On 30. Apr 2020, at 11:05, Robert Munteanu <ro...@apache.org>
>>>>> wrote:
>>>>> 
>>>>> On Thu, 2020-04-30 at 10:06 +0200, Carsten Ziegeler wrote:
>>>>>> As far as I remember, it checks that the artifacts (jars)
>>>>>> have
>>>>>> the 
>>>>>> required legal files, LICENSE and NOTICE.
>>>>>> But given that this plugin is totally outdated, its probably
>>>>>> safer
>>>>>> to 
>>>>>> remove it
>>>>> 
>>>>> It would be good to still check for the legal files though.
>>>>> 
>>>>> Robert
>>>>> 
>>>>>> Regards
>>>>>> Carsten
>>>>>> 
>>>>>> On 30.04.2020 09:58, Stefan Seifert wrote:
>>>>>>> +1 to remove it
>>>>>>> 
>>>>>>> it seems the plugin was already present in the very first
>>>>>>> commit
>>>>>>> 2009 "move sling to new TLP" location.
>>>>>>> i've no idea what it does.
>>>>>>> 
>>>>>>> stefan
>>>>>>> 
>>>>>>>> -----Original Message-----
>>>>>>>> From: Andreas Schaefer <sc...@me.com.INVALID>
>>>>>>>> Sent: Thursday, April 30, 2020 1:12 AM
>>>>>>>> To: dev <de...@sling.apache.org>
>>>>>>>> Subject: Ianal Maven Plugin?
>>>>>>>> 
>>>>>>>> Hi
>>>>>>>> 
>>>>>>>> I just stumbled over an issue with Ianal Maven Plugin and
>>>>>>>> when I
>>>>>>>> wanted to
>>>>>>>> see what it is looking for I discovered that the project
>>>>>>>> does
>>>>>>>> not
>>>>>>>> exist
>>>>>>>> anymore nor does a documentation page.
>>>>>>>> The plugin was released 2008 as alpha and nothing since.
>>>>>>>> 
>>>>>>>> Shouldn’t we stop using that plugin or find / create a
>>>>>>>> replacement for it?
>>>>>>>> 
>>>>>>>> Cheers - Andy
>