You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/30 17:09:09 UTC

[GitHub] [apisix] jenskeiner opened a new pull request #2902: feat: Make headers set by openid-connect plugin more configurable.

jenskeiner opened a new pull request #2902:
URL: https://github.com/apache/apisix/pull/2902


   ### What this PR does / why we need it:
   This change allows to inject a path to a custom TLS root CA certificates store through the configuration file. Needed in cases where custom root CA certificates are used and they are not contained in the default bundle used.
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #2902: feat: Allow to inject custom TLS root CA certificates store.

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2902:
URL: https://github.com/apache/apisix/pull/2902#issuecomment-736150203


   I am afraid we already have this feature https://github.com/apache/apisix/commit/d87ce33485254279ef3b7ac622e2c7dc8a9429b5:
   https://github.com/apache/apisix/blob/9dfe697b644691509b55cd7ec58188b33dd3e792/conf/config-default.yaml#L108


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] jenskeiner commented on pull request #2902: feat: Allow to inject custom TLS root CA certificates store.

Posted by GitBox <gi...@apache.org>.
jenskeiner commented on pull request #2902:
URL: https://github.com/apache/apisix/pull/2902#issuecomment-736628893


   > I am afraid we already have this feature [d87ce33](https://github.com/apache/apisix/commit/d87ce33485254279ef3b7ac622e2c7dc8a9429b5):
   > 
   > https://github.com/apache/apisix/blob/9dfe697b644691509b55cd7ec58188b33dd3e792/conf/config-default.yaml#L108
   
   I see it now, thanks. Not sure why I've missed it in the first place. Was probably looking at a tag, not master. Closing this one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] jenskeiner closed pull request #2902: feat: Allow to inject custom TLS root CA certificates store.

Posted by GitBox <gi...@apache.org>.
jenskeiner closed pull request #2902:
URL: https://github.com/apache/apisix/pull/2902


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org