You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Anand V Nath (JIRA)" <de...@myfaces.apache.org> on 2012/09/06 07:52:07 UTC

[jira] [Created] (TRINIDAD-2309) perf: change the concurrenthashmap to arraymap and fix the golden files

Anand V Nath created TRINIDAD-2309:
--------------------------------------

             Summary: perf: change the concurrenthashmap to arraymap and fix the golden files
                 Key: TRINIDAD-2309
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2309
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Skinning
    Affects Versions: 2.0.1-core, 2.1.0-core
            Reporter: Anand V Nath
            Priority: Minor


Replace the usage of ConcurrentHashMap with ArrayMap in XhtmlSkin and StyleSheetDocument. These maps are populated once and not modified else where. So usage of ConcurrentHashMap is unnecessary here, ArrayMap should suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TRINIDAD-2309) perf: change the concurrenthashmap to arraymap and fix the golden files

Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott O'Bryan updated TRINIDAD-2309:
------------------------------------

    Resolution: Fixed
      Assignee: Scott O'Bryan
        Status: Resolved  (was: Patch Available)

Committed to 2.0.x 1384015
                
> perf: change the concurrenthashmap to arraymap and fix the golden files
> -----------------------------------------------------------------------
>
>                 Key: TRINIDAD-2309
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2309
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 2.0.1-core, 2.1.0-core
>            Reporter: Anand V Nath
>            Assignee: Scott O'Bryan
>            Priority: Minor
>             Fix For: 2.0.2-core, 2.1.0-core
>
>         Attachments: jira-2309.patch
>
>
> Replace the usage of ConcurrentHashMap with ArrayMap in XhtmlSkin and StyleSheetDocument. These maps are populated once and not modified else where. So usage of ConcurrentHashMap is unnecessary here, ArrayMap should suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Commit Request] TRINIDAD-2309 perf: change the concurrenthashmap to arraymap and fix the golden files

Posted by Anand Nath <an...@oracle.com>.
Hi,

Can someone commit the patch attached to jira issue TRINIDAD-2309?

Thanks
Anand
On 9/6/2012 11:24 AM, Anand V Nath (JIRA) wrote:
>       [ https://issues.apache.org/jira/browse/TRINIDAD-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Anand V Nath updated TRINIDAD-2309:
> -----------------------------------
>
>      Status: Patch Available  (was: Open)
>      
>> perf: change the concurrenthashmap to arraymap and fix the golden files
>> -----------------------------------------------------------------------
>>
>>                  Key: TRINIDAD-2309
>>                  URL: https://issues.apache.org/jira/browse/TRINIDAD-2309
>>              Project: MyFaces Trinidad
>>           Issue Type: Bug
>>           Components: Skinning
>>     Affects Versions: 2.0.1-core, 2.1.0-core
>>             Reporter: Anand V Nath
>>             Priority: Minor
>>              Fix For: 2.0.2-core, 2.1.0-core
>>
>>
>> Replace the usage of ConcurrentHashMap with ArrayMap in XhtmlSkin and StyleSheetDocument. These maps are populated once and not modified else where. So usage of ConcurrentHashMap is unnecessary here, ArrayMap should suffice.
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (TRINIDAD-2309) perf: change the concurrenthashmap to arraymap and fix the golden files

Posted by "Anand V Nath (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anand V Nath updated TRINIDAD-2309:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> perf: change the concurrenthashmap to arraymap and fix the golden files
> -----------------------------------------------------------------------
>
>                 Key: TRINIDAD-2309
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2309
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 2.0.1-core, 2.1.0-core
>            Reporter: Anand V Nath
>            Priority: Minor
>             Fix For: 2.0.2-core, 2.1.0-core
>
>
> Replace the usage of ConcurrentHashMap with ArrayMap in XhtmlSkin and StyleSheetDocument. These maps are populated once and not modified else where. So usage of ConcurrentHashMap is unnecessary here, ArrayMap should suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2309) perf: change the concurrenthashmap to arraymap and fix the golden files

Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454090#comment-13454090 ] 

Scott O'Bryan commented on TRINIDAD-2309:
-----------------------------------------

Committed to trunk 1384014
                
> perf: change the concurrenthashmap to arraymap and fix the golden files
> -----------------------------------------------------------------------
>
>                 Key: TRINIDAD-2309
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2309
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 2.0.1-core, 2.1.0-core
>            Reporter: Anand V Nath
>            Priority: Minor
>             Fix For: 2.0.2-core, 2.1.0-core
>
>         Attachments: jira-2309.patch
>
>
> Replace the usage of ConcurrentHashMap with ArrayMap in XhtmlSkin and StyleSheetDocument. These maps are populated once and not modified else where. So usage of ConcurrentHashMap is unnecessary here, ArrayMap should suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira