You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/14 14:58:51 UTC
[GitHub] [airflow] potiuk commented on pull request #22284: Move the database configuration to a new section
potiuk commented on PR #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1126731650
Yes. I looked at it already and I could confirm that `conf.as_dict()` will work wrongly in this case (and this is the root cause). Currently when you run conf.as_dict(), the "database" entries will get the "defaults" (sqlite://) for MySQL and "core" will get the one that is set in the config. Which will effective replace the configuration specified in "defaults" when --raw is used.
I am not the author of this part, but after looking there I think simply conf.as_dict has not been written with such deprecations in mind (and likely some users could have some problems before because of other deprecations).
I think - "logically" speaking I think when the depraction has corresponding value in the conf - it just should not be exported by the "as_dict()". i am looking at fixing it in an upcoming pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org