You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2017/11/16 01:44:41 UTC
hbase git commit: HBASE-19262 Revisit checkstyle rules
Repository: hbase
Updated Branches:
refs/heads/master 600fdee84 -> d4babbf06
HBASE-19262 Revisit checkstyle rules
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/d4babbf0
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/d4babbf0
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/d4babbf0
Branch: refs/heads/master
Commit: d4babbf060a99222c7ebe60ee1b0f4197411ea37
Parents: 600fdee
Author: zhangduo <zh...@apache.org>
Authored: Wed Nov 15 15:38:02 2017 +0800
Committer: zhangduo <zh...@apache.org>
Committed: Thu Nov 16 09:43:08 2017 +0800
----------------------------------------------------------------------
.../src/main/resources/hbase/checkstyle-suppressions.xml | 3 ++-
hbase-checkstyle/src/main/resources/hbase/checkstyle.xml | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/d4babbf0/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
----------------------------------------------------------------------
diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
index 46009e9..1ecae86 100644
--- a/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
+++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
@@ -33,5 +33,6 @@
<suppressions>
<suppress checks="." files=".*/generated/.*\.java"/>
<suppress checks="." files=".*/generated-jamon/.*\.java"/>
- <suppress checks="MagicNumberCheck" files=".*Test\.java"/>
+ <suppress checks="MagicNumberCheck" files=".*/src/test/.*\.java"/>
+ <suppress checks="VisibilityModifier" files=".*/src/test/.*\.java"/>
</suppressions>
http://git-wip-us.apache.org/repos/asf/hbase/blob/d4babbf0/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
----------------------------------------------------------------------
diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
index b423095..2240096 100644
--- a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
+++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
@@ -67,6 +67,7 @@
http://checkstyle.sourceforge.net/config_imports.html -->
<module name="AvoidStarImport"/>
<module name="ImportOrder">
+ <property name="groups" value="*,org.apache.hadoop.hbase.shaded"/>
<property name="option" value="top" />
<property name="ordered" value="true"/>
<property name="sortStaticImportsAlphabetically" value="true"/>