You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/28 16:32:58 UTC

[GitHub] [flink] PatrickRen commented on a change in pull request #15397: [FLINK-21817][connector/common] Remove split assignment tracker from coordinator state

PatrickRen commented on a change in pull request #15397:
URL: https://github.com/apache/flink/pull/15397#discussion_r602900463



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SplitAssignmentTracker.java
##########
@@ -71,7 +68,8 @@ public void snapshotState(
         // Include the uncheckpointed assignments to the snapshot.
         assignmentsByCheckpointId.put(checkpointId, uncheckpointedAssignments);
         uncheckpointedAssignments = new HashMap<>();
-        writeAssignmentsByCheckpointId(assignmentsByCheckpointId, splitSerializer, out);

Review comment:
       Thanks @kezhuw ! That's a good catch. I think writing an empty map here will keep the forward compatibility. I'll update my code later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org