You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/06 03:56:37 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue, #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
terrymanu opened a new issue, #20815:
URL: https://github.com/apache/shardingsphere/issues/20815
Catch exception is not recommended, please investigate the class DataSourcePropertiesValidator, and try to instead of catch exception to SQLException and ShardingSphereInternalException.
Just search `// TODO check why catch exception here, can it simplify to catch SQLException and ShardingSphereInternalException?` to find the codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #20815:
URL: https://github.com/apache/shardingsphere/issues/20815#issuecomment-1333319012
Hi @tianhao960
Is there any progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #20815:
URL: https://github.com/apache/shardingsphere/issues/20815#issuecomment-1272348600
Hello , this issue has not received a reply for several days.
This issue is supposed to be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] closed issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
URL: https://github.com/apache/shardingsphere/issues/20815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tianhao960 commented on issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
tianhao960 commented on issue #20815:
URL: https://github.com/apache/shardingsphere/issues/20815#issuecomment-1275510204
> > hi, @terrymanu , I'd like to try this.
>
> @tianhao960 Assigned. Could we finish this issue in 5.2.1?
hi, I am afraid I need some time to finish this and before 5.2.2 release, it could be done. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tianhao960 commented on issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
tianhao960 commented on issue #20815:
URL: https://github.com/apache/shardingsphere/issues/20815#issuecomment-1250422888
hi, @terrymanu , I'd like to try this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20815:
URL: https://github.com/apache/shardingsphere/issues/20815#issuecomment-1364914519
It's already fixed by #22217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20815:
URL: https://github.com/apache/shardingsphere/issues/20815#issuecomment-1275436471
> hi, @terrymanu , I'd like to try this.
@tianhao960 Assigned. Could we finish this issue in 5.2.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tianhao960 commented on issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
tianhao960 commented on issue #20815:
URL: https://github.com/apache/shardingsphere/issues/20815#issuecomment-1293152190
it seems that
`DataSourcePoolCreator.create(dataSourceProps);`
will throw Exception which caused by `@SneakyThrows(ReflectiveOperationException.class)` at class DataSourcePoolCreator and ShardingSphereServiceLoader.
and DataSourcePropertiesValidator can not catch checked exception ReflectiveOperationException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz closed issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
Posted by GitBox <gi...@apache.org>.
sandynz closed issue #20815: DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only
URL: https://github.com/apache/shardingsphere/issues/20815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org