You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by zhouxiangxiang <gi...@git.apache.org> on 2016/06/29 07:30:32 UTC
[GitHub] trafficserver pull request #765: Update HttpConfig.h
GitHub user zhouxiangxiang opened a pull request:
https://github.com/apache/trafficserver/pull/765
Update HttpConfig.h
memory leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhouxiangxiang/trafficserver patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/765.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #765
----
commit 777f40ada1b21cf234cc0023934b491e87f9d2f3
Author: kreats <zh...@gmail.com>
Date: 2016-06-29T07:29:46Z
Update HttpConfig.h
memory leak
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #765: Update HttpConfig.h
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/765
Yeah, maybe we should close this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #765: Update HttpConfig.h
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/765
Looks reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #765: Update HttpConfig.h
Posted by zhouxiangxiang <gi...@git.apache.org>.
Github user zhouxiangxiang closed the pull request at:
https://github.com/apache/trafficserver/pull/765
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #765: Update HttpConfig.h
Posted by zhouxiangxiang <gi...@git.apache.org>.
Github user zhouxiangxiang commented on the issue:
https://github.com/apache/trafficserver/pull/765
@zwoop I'm a newbie of ats.
I use it in my company, and the memory is always increasing.
The memory's management puzzle me a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #765: Update HttpConfig.h
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/765
@jpeach points out that the existing code should recursively free the chain of port objects. So we are not understanding the leak case. How did you detect this leak? And can you link the JIRA that describes the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #765: Update HttpConfig.h
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/765
Bike shedding and side-tracking a bit, but we should encourage to not use the pattern
if (foo)
delete foo;
it should be just
delete foo;
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---