You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2024/01/24 10:32:58 UTC
[PR] [FLINK-32684][rpc] Introduces RpcOptions and deprecates AkkaOptions [flink]
XComp opened a new pull request, #24188:
URL: https://github.com/apache/flink/pull/24188
## What is the purpose of the change
The name {{AkkaOptions}} is wrong after replacing Akka with Apache Pekko in FLINK-32468. The new options should be named more generically to avoid running into the same issue in the future when/if we decide to replace Pekko with gRPC (FLINK-29281).
## Brief change log
* Renames `AkkaOptions` into `RpcOptions` using the IDE
* Copied `RpcOptions` to `AkkaOptions` and renamed the class to `AkkaOptions` adding a `@Deprecated` annotation
* Removes deprecated options from `RpcOptions`
* Reference corresponding `RpcOptions` in `AkkaOptions`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32684][rpc] Introduces RpcOptions and deprecates AkkaOptions [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24188:
URL: https://github.com/apache/flink/pull/24188#issuecomment-1907874885
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e95ca97cb6a0b2d8f04c08dee403927efe77c8e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e95ca97cb6a0b2d8f04c08dee403927efe77c8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e95ca97cb6a0b2d8f04c08dee403927efe77c8e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32684][rpc] Introduces RpcOptions and deprecates AkkaOptions [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #24188:
URL: https://github.com/apache/flink/pull/24188#issuecomment-1916358082
I verified in the release meeting today that this PR still is allowed to make it into master even after feature freeze.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32684][rpc] Introduces RpcOptions and deprecates AkkaOptions [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #24188:
URL: https://github.com/apache/flink/pull/24188#issuecomment-1908619130
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32684][rpc] Introduces RpcOptions and deprecates AkkaOptions [flink]
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk commented on PR #24188:
URL: https://github.com/apache/flink/pull/24188#issuecomment-1914593695
Sorry I missed the review request notification days ago. @XComp
I will take a look right away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32684][rpc] Introduces RpcOptions and deprecates AkkaOptions [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #24188:
URL: https://github.com/apache/flink/pull/24188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32684][rpc] Introduces RpcOptions and deprecates AkkaOptions [flink]
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk commented on code in PR #24188:
URL: https://github.com/apache/flink/pull/24188#discussion_r1469551266
##########
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java:
##########
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.annotation.docs.Documentation;
+
+import java.time.Duration;
+
+/**
+ * RPC configuration options.
+ *
+ * @deprecated Use {@link RpcOptions} instead.
+ */
+@PublicEvolving
+@Deprecated // since 1.19.0
+public class AkkaOptions {
+
+ @Internal
+ @Documentation.ExcludeFromDocumentation("Internal use only")
+ public static final ConfigOption<Boolean> FORCE_RPC_INVOCATION_SERIALIZATION =
Review Comment:
I think it is safe to directly remove it because it is not exposed as a public interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org