You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "r-richmond (JIRA)" <ji...@apache.org> on 2017/02/28 23:59:46 UTC
[jira] [Updated] (AIRFLOW-926) jdbc connector is broken due to
jaydebeapi api update
[ https://issues.apache.org/jira/browse/AIRFLOW-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
r-richmond updated AIRFLOW-926:
-------------------------------
Description:
marking this as major as JDBC hooks are broken but it probably belongs somewhere between major and minor.... feel free to adjust
there is an incompability between jaydebapi==1.0.0 and airflow as it sits now. they changed their connect api. Its a small change but it breaks the jdbc hook for the moment. the jdbc hook [code](https://github.com/apache/incubator-airflow/blob/ff45d8f2218a8da9328161aa66d004c3db3b367e/airflow/hooks/jdbc_hook.py#L55) should look like this (working on a pull request right now but this is the fix + something for multiple jars that are comma separated)
{code:python}
conn = jaydebeapi.connect(jclassname=jdbc_driver_name,
url=host,
driver_args=[str(login), str(psw)],
jars=jdbc_driver_loc.split(sep=","))
{code}
anyways that should be changed and [setup.py](https://github.com/apache/incubator-airflow/blob/4f52db317f16b431ef06e61ffebd8cc6aecd50c1/setup.py#L143) should be updated to reflect
`jdbc = ['jaydebeapi>=1.0.0']`
[jaydebeapi updated api](https://github.com/baztian/jaydebeapi/commit/2640445de036def2169514aa56e5ad9ced246b16#diff-a51683c99849d299a6cb9e6c4bcec328R349) jan 9 2017
was:
marking this as major as JDBC hooks are broken but it probably belongs somewhere between major and minor.... feel free to adjust
there is an incompability between jaydebapi==1.0.0 and airflow as it sits now. they changed their connect api. Its a small change but it breaks the jdbc hook for the moment. the jdbc hook [code](https://github.com/apache/incubator-airflow/blob/ff45d8f2218a8da9328161aa66d004c3db3b367e/airflow/hooks/jdbc_hook.py#L55) should look like this (working on a pull request right now but this is the fix + something for multiple jars that are comma separated)
```python
conn = jaydebeapi.connect(jclassname=jdbc_driver_name,
url=host,
driver_args=[str(login), str(psw)],
jars=jdbc_driver_loc.split(sep=","))
```
anyways that should be changed and [setup.py](https://github.com/apache/incubator-airflow/blob/4f52db317f16b431ef06e61ffebd8cc6aecd50c1/setup.py#L143) should be updated to reflect
`jdbc = ['jaydebeapi>=1.0.0']`
[jaydebeapi updated api](https://github.com/baztian/jaydebeapi/commit/2640445de036def2169514aa56e5ad9ced246b16#diff-a51683c99849d299a6cb9e6c4bcec328R349) jan 9 2017
> jdbc connector is broken due to jaydebeapi api update
> -----------------------------------------------------
>
> Key: AIRFLOW-926
> URL: https://issues.apache.org/jira/browse/AIRFLOW-926
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: Airflow 1.8, Airflow 1.7.1.3
> Reporter: r-richmond
>
> marking this as major as JDBC hooks are broken but it probably belongs somewhere between major and minor.... feel free to adjust
> there is an incompability between jaydebapi==1.0.0 and airflow as it sits now. they changed their connect api. Its a small change but it breaks the jdbc hook for the moment. the jdbc hook [code](https://github.com/apache/incubator-airflow/blob/ff45d8f2218a8da9328161aa66d004c3db3b367e/airflow/hooks/jdbc_hook.py#L55) should look like this (working on a pull request right now but this is the fix + something for multiple jars that are comma separated)
> {code:python}
> conn = jaydebeapi.connect(jclassname=jdbc_driver_name,
> url=host,
> driver_args=[str(login), str(psw)],
> jars=jdbc_driver_loc.split(sep=","))
> {code}
> anyways that should be changed and [setup.py](https://github.com/apache/incubator-airflow/blob/4f52db317f16b431ef06e61ffebd8cc6aecd50c1/setup.py#L143) should be updated to reflect
> `jdbc = ['jaydebeapi>=1.0.0']`
> [jaydebeapi updated api](https://github.com/baztian/jaydebeapi/commit/2640445de036def2169514aa56e5ad9ced246b16#diff-a51683c99849d299a6cb9e6c4bcec328R349) jan 9 2017
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)