You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/06 17:06:51 UTC

[GitHub] [helix] lei-xia edited a comment on pull request #1436: Not to reuse data accessor in Helix customized state provider

lei-xia edited a comment on pull request #1436:
URL: https://github.com/apache/helix/pull/1436#issuecomment-704416624


   There are two logic changes here, I know both of them are short, but can we break it down to two PRs? 1) Catch the exception and return false in GroupCommit, 2) Do not cache dataAccessor in CustomizedStateProvider.  Those two changes are independent of each other.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org