You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ga...@apache.org on 2018/09/07 23:59:31 UTC
[mesos] branch 1.5.x updated (3605d7c -> fd36c84)
This is an automated email from the ASF dual-hosted git repository.
gaston pushed a change to branch 1.5.x
in repository https://gitbox.apache.org/repos/asf/mesos.git.
from 3605d7c Added MESOS-8568 to the 1.5.2 CHANGELOG.
new 703e8e6 Revert "Set 'Connection: close' in the master's streaming API responses."
new fd36c84 Revert "Added MESOS-9189 to the 1.5.2 CHANGELOG."
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGELOG | 3 ---
src/master/http.cpp | 29 -----------------------------
2 files changed, 32 deletions(-)
[mesos] 01/02: Revert "Set 'Connection: close' in the master's
streaming API responses."
Posted by ga...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gaston pushed a commit to branch 1.5.x
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 703e8e6a074abe7ec5c6b343beeb9c19467a510a
Author: Gastón Kleiman <ga...@apache.org>
AuthorDate: Fri Sep 7 16:47:17 2018 -0700
Revert "Set 'Connection: close' in the master's streaming API responses."
This reverts commit 64cc58664730395a906b7ead48622e05c402fe98.
---
src/master/http.cpp | 29 -----------------------------
1 file changed, 29 deletions(-)
diff --git a/src/master/http.cpp b/src/master/http.cpp
index 03e6eb0..1f9aac4 100644
--- a/src/master/http.cpp
+++ b/src/master/http.cpp
@@ -852,20 +852,6 @@ Future<Response> Master::Http::subscribe(
Pipe pipe;
OK ok;
- // Since the response is infinite, set the 'Connection: close'
- // header to help indicate to intermediaries (e.g. load
- // balancers, proxies) that the connection SHOULD NOT be
- // re-used. Some intermediaries leave the connection to the
- // server open when a client disconnects in order to re-use
- // the connection as an optimization. In these cases, the
- // subscribers do not get removed when the end client
- // disconnects!
- //
- // TODO(bmahler): Libprocess currently doesn't close the
- // the connection based on a handler setting this header,
- // but it doesn't matter here since the response is infinite.
- ok.headers["Connection"] = "close";
-
ok.headers["Content-Type"] = stringify(contentType);
ok.type = Response::PIPE;
ok.reader = pipe.reader();
@@ -1047,21 +1033,6 @@ Future<Response> Master::Http::scheduler(
Pipe pipe;
OK ok;
-
- // Since the response is infinite, set the 'Connection: close'
- // header to help indicate to intermediaries (e.g. load
- // balancers, proxies) that the connection SHOULD NOT be
- // re-used. Some intermediaries leave the connection to the
- // server open when a client disconnects in order to re-use
- // the connection as an optimization. In these cases, the
- // scheduler would not get removed when it disconnects from
- // the intermediary!
- //
- // TODO(bmahler): Libprocess currently doesn't close the
- // the connection based on a handler setting this header,
- // but it doesn't matter here since the response is infinite.
- ok.headers["Connection"] = "close";
-
ok.headers["Content-Type"] = stringify(acceptType);
ok.type = Response::PIPE;
[mesos] 02/02: Revert "Added MESOS-9189 to the 1.5.2 CHANGELOG."
Posted by ga...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gaston pushed a commit to branch 1.5.x
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit fd36c846f4b433f3011742838176e11aae71f42b
Author: Gastón Kleiman <ga...@apache.org>
AuthorDate: Fri Sep 7 16:47:24 2018 -0700
Revert "Added MESOS-9189 to the 1.5.2 CHANGELOG."
This reverts commit 5fb1c8eedc63c06c05c02651bf4fb7235fdaa777.
---
CHANGELOG | 3 ---
1 file changed, 3 deletions(-)
diff --git a/CHANGELOG b/CHANGELOG
index 5504e6a..4709e94 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -34,9 +34,6 @@ Release Notes - Mesos - Version 1.5.2 (WIP)
* [MESOS-9170] - Zookeeper doesn't compile with newer gcc due to format error.
* [MESOS-9196] - Removing rootfs mounts may fail with EBUSY.
-** Improvement
- * [MESOS-9189] - Include 'Connection: close' header in master streaming API responses.
-
Release Notes - Mesos - Version 1.5.1
-------------------------------------------