You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/20 21:35:34 UTC
[GitHub] [maven] gnodet commented on a diff in pull request #838: Fix project versions not updated during release
gnodet commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001138925
##########
maven-model/pom.xml:
##########
@@ -64,7 +64,7 @@ under the License.
<artifactItem>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
Given the version is not changed during the release, this will break again. Would you mind changing to `${project.version}` instead ?
##########
maven-model/src/test/resources/xml/pom.xml:
##########
@@ -25,7 +25,7 @@ under the License.
<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
This file is a test pom which is simply loaded, the version number is not important. For clarity, if we really want to change it, maybe use something like `dummy-version` instead of something that can be misinterpreted as a real version.
##########
maven-settings/pom.xml:
##########
@@ -68,7 +68,7 @@ under the License.
<artifactItem>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-settings</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
Use `${project.version}`.
##########
maven-toolchain-model/pom.xml:
##########
@@ -67,7 +67,7 @@ under the License.
<artifactItem>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-toolchain</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
Use `${project.version}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org