You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/10/24 17:06:19 UTC

[PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

pjfanning opened a new pull request, #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#discussion_r1375242330


##########
project/plugins.sbt:
##########
@@ -7,11 +7,13 @@
  * This file is part of the Apache Pekko project, which was derived from Akka.
  */
 
+dependencyOverrides += "org.scala-lang.modules" %% "scala-xml" % "2.2.0"

Review Comment:
   Some of the old sbt plugins have scala-xml v1 dependencies. pekko-grpc-sbt-plugin now brings in scala-xml v2 transitively. So I need to force sbt to use scala-xml v2 to stop it failing to run due to mismatched scala-xml versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#issuecomment-1783793330

   > > Approving, need to double check if #269 is required.
   > 
   > 269 is not needed if this is merged
   
   Go ahead and merge then


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#discussion_r1370800099


##########
project/plugins.sbt:
##########
@@ -34,7 +36,7 @@ addSbtPlugin(("com.lightbend.paradox" % "sbt-paradox-project-info" % "2.0.0").fo
 addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
 addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2")
 addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
-// Pekko gRPC -- sync with version in Dependencies.scala:29
-addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.0")
+// Pekko gRPC -- sync with PekkoGrpcBinaryVersion in Dependencies.scala

Review Comment:
   Dependencies.PekkoGrpcBinaryVersion is only used in doc generation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#discussion_r1370611223


##########
project/plugins.sbt:
##########
@@ -34,7 +36,7 @@ addSbtPlugin(("com.lightbend.paradox" % "sbt-paradox-project-info" % "2.0.0").fo
 addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
 addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2")
 addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
-// Pekko gRPC -- sync with version in Dependencies.scala:29
-addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.0")
+// Pekko gRPC -- sync with PekkoGrpcBinaryVersion in Dependencies.scala

Review Comment:
   @pjfanning Also need to update it in `Dependencies.scala`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#discussion_r1370697634


##########
project/plugins.sbt:
##########
@@ -34,7 +36,7 @@ addSbtPlugin(("com.lightbend.paradox" % "sbt-paradox-project-info" % "2.0.0").fo
 addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
 addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2")
 addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
-// Pekko gRPC -- sync with version in Dependencies.scala:29
-addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.0")
+// Pekko gRPC -- sync with PekkoGrpcBinaryVersion in Dependencies.scala

Review Comment:
   > I can't find anything to update in Dependencies.scala.
   > 
   > This is all I can find.
   > ```
   >   // Sync with plugins.sbt
   >   val PekkoGrpcBinaryVersion = "current"
   > ```
   > 
   > Do you want `current` changed to `1.0.1`? 
   
   Hmm that sounds off for the same reasons as pekko http where other caused issues. I am getting the nagging feeling that we should leave this to 1.0.0 and setup a system where we build against snapshots as a nightly job



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#discussion_r1373057657


##########
project/plugins.sbt:
##########
@@ -34,7 +36,7 @@ addSbtPlugin(("com.lightbend.paradox" % "sbt-paradox-project-info" % "2.0.0").fo
 addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
 addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2")
 addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
-// Pekko gRPC -- sync with version in Dependencies.scala:29
-addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.0")
+// Pekko gRPC -- sync with PekkoGrpcBinaryVersion in Dependencies.scala

Review Comment:
   @mdedetrich one of the main reasons for pekko-grpc 1.0.1 release was to tidy up its dependency - dependency issues that affect pekko-connectors.
   
   Pekko HTTP is a special case. It has that runtime check for minimum pekko version that I don't believe is common in our runtime code generally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#discussion_r1370686052


##########
project/plugins.sbt:
##########
@@ -34,7 +36,7 @@ addSbtPlugin(("com.lightbend.paradox" % "sbt-paradox-project-info" % "2.0.0").fo
 addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
 addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2")
 addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
-// Pekko gRPC -- sync with version in Dependencies.scala:29
-addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.0")
+// Pekko gRPC -- sync with PekkoGrpcBinaryVersion in Dependencies.scala

Review Comment:
   I can't find anything to update in Dependencies.scala.
   
   This is all I can find.
   ```
     // Sync with plugins.sbt
     val PekkoGrpcBinaryVersion = "current"
   ```
   
   Do you want `current` changed to `1.0.1`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#issuecomment-1783791260

   > Approving, need to double check if #269 is required.
   
   269 is not needed if this is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#discussion_r1375214343


##########
project/plugins.sbt:
##########
@@ -34,7 +36,7 @@ addSbtPlugin(("com.lightbend.paradox" % "sbt-paradox-project-info" % "2.0.0").fo
 addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
 addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2")
 addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
-// Pekko gRPC -- sync with version in Dependencies.scala:29
-addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.0")
+// Pekko gRPC -- sync with PekkoGrpcBinaryVersion in Dependencies.scala

Review Comment:
   This was a big misunderstanding on my part, approving PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] pekko grpc 1.0.1 release [incubator-pekko-connectors]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #266:
URL: https://github.com/apache/incubator-pekko-connectors/pull/266#discussion_r1375214433


##########
project/plugins.sbt:
##########
@@ -7,11 +7,13 @@
  * This file is part of the Apache Pekko project, which was derived from Akka.
  */
 
+dependencyOverrides += "org.scala-lang.modules" %% "scala-xml" % "2.2.0"

Review Comment:
   @pjfanning Why is this here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org