You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ku...@apache.org on 2018/07/20 09:46:08 UTC
carbondata git commit: [CARBONDATA-2758] Fix for filling data with
enabled Local Dictionary having continous null values greater than default
batch size throws array index out of bound
Repository: carbondata
Updated Branches:
refs/heads/master b047918c7 -> 4da03f2dd
[CARBONDATA-2758] Fix for filling data with enabled Local Dictionary having continous null values greater than default batch size throws array index out of bound
Description: Before vector filled with row so whenever the batch for a particular
row is finished it should need to start again with zero into next batch.
Sol: vector offset already maintains the same.
This closes #2527
Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/4da03f2d
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/4da03f2d
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/4da03f2d
Branch: refs/heads/master
Commit: 4da03f2dd28671bc7e869e422167cfe5d27a9fc3
Parents: b047918
Author: Jatin <ja...@knoldus.in>
Authored: Thu Jul 19 14:36:18 2018 +0530
Committer: kumarvishal09 <ku...@gmail.com>
Committed: Fri Jul 20 15:15:35 2018 +0530
----------------------------------------------------------------------
.../chunk/store/impl/LocalDictDimensionDataChunkStore.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/carbondata/blob/4da03f2d/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java b/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
index a6bd23d..0d06f61 100644
--- a/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
+++ b/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
@@ -60,8 +60,8 @@ public class LocalDictDimensionDataChunkStore implements DimensionDataChunkStore
}
int surrogate = dimensionDataChunkStore.getSurrogate(rowId);
if (surrogate == CarbonCommonConstants.MEMBER_DEFAULT_VAL_SURROGATE_KEY) {
- vector.putNull(rowId);
- vector.getDictionaryVector().putNull(rowId);
+ vector.putNull(vectorRow);
+ vector.getDictionaryVector().putNull(vectorRow);
return;
}
vector.putNotNull(vectorRow);