[GitHub] bharatviswa504 commented on issue #523: HDDS-623. On SCM UI, Node Manager info is empty

[GitBox <gi...@apache.org>]

bharatviswa504 commented on issue #523: HDDS-623. On SCM UI, Node Manager info is empty
URL: https://github.com/apache/hadoop/pull/523#issuecomment-468449859
 
 
   +1 LGTM. (Not a frontend guy, but as this is not adding any code, so had taken a look at it)
   
   But one more thing I have observed is 
   Block Manager: Open containers this is also broken, as currently in the code we have a TODO for this
   in BlockManagerImpl.java
   
   This also needs to be fixed.
   ```
    @Override
     public int getOpenContainersNo() {
       return 0;
       // TODO : FIX ME : The open container being a single number does not make
       // sense.
       // We have to get open containers by Replication Type and Replication
       // factor. Hence returning 0 for now.
       // containers.get(HddsProtos.LifeCycleState.OPEN).size();
     }
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org