You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Lieven Govaerts <lg...@mobsol.be> on 2007/06/23 22:42:35 UTC
[PATCH] Handle failed authentication in ra_serf
Attached is a small patch that handles failed authentication in ra_serf.
With current trunk when you provide wrong credentials for four times svn
will get in an endless loop.
I couldn't find an error code for 'Authentication failed', it seems to
me that other ra layers are incorrectly using Authori*z*ation failed as
error message.
Unless anyone objects, I'll commit this tomorrow.
Lieven
[[[
Handle failed authentication in ra_serf.
* subversion/include/svn_error_codes.h
(global): add new error code SVN_ERR_AUTHN_FAILED.
* subversion/libsvn_ra_serf/util.c
(handle_response): if authn fails, return an error.
]]]
Re: [PATCH] Handle failed authentication in ra_serf
Posted by Lieven Govaerts <sv...@mobsol.be>.
Justin Erenkrantz wrote:
> On 6/23/07, Lieven Govaerts <lg...@mobsol.be> wrote:
>>
>> Attached is a small patch that handles failed authentication in ra_serf.
>> With current trunk when you provide wrong credentials for four times svn
>> will get in an endless loop.
>>
>> I couldn't find an error code for 'Authentication failed', it seems to
>> me that other ra layers are incorrectly using Authori*z*ation failed as
>> error message.
>>
>> Unless anyone objects, I'll commit this tomorrow.
>
> Looks good - one minor suggestion: tweak handle_auth to return
> svn_error_t and return Authentication failed error inside handle_auth
> (and still do the pending_error set in handle_response). For the
> abort() cases we talked about on IRC, we can return more informative
> error descriptions as well... -- justin
Yep, good point. r25519 already removes some of the abort() calls.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Handle failed authentication in ra_serf
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On 6/23/07, Lieven Govaerts <lg...@mobsol.be> wrote:
>
> Attached is a small patch that handles failed authentication in ra_serf.
> With current trunk when you provide wrong credentials for four times svn
> will get in an endless loop.
>
> I couldn't find an error code for 'Authentication failed', it seems to
> me that other ra layers are incorrectly using Authori*z*ation failed as
> error message.
>
> Unless anyone objects, I'll commit this tomorrow.
Looks good - one minor suggestion: tweak handle_auth to return
svn_error_t and return Authentication failed error inside handle_auth
(and still do the pending_error set in handle_response). For the
abort() cases we talked about on IRC, we can return more informative
error descriptions as well... -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org