You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Vadim Geshel (JIRA)" <ji...@apache.org> on 2008/04/18 20:08:23 UTC
[jira] Created: (PIG-213) Non-static Log objects in
org.apache.pig.data.* classes are inefficient
Non-static Log objects in org.apache.pig.data.* classes are inefficient
-----------------------------------------------------------------------
Key: PIG-213
URL: https://issues.apache.org/jira/browse/PIG-213
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.1.0
Reporter: Vadim Geshel
Priority: Minor
Attachments: logging.patch
LogFactory.getLog called from the constructor of Tuple accounts for significant percentage of my job's running time. The proposed fix is to make the Log fields static (which is generally standard practice).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-213) Non-static Log objects in
org.apache.pig.data.* classes are inefficient
Posted by "Vadim Geshel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vadim Geshel updated PIG-213:
-----------------------------
Attachment: logging.patch
> Non-static Log objects in org.apache.pig.data.* classes are inefficient
> -----------------------------------------------------------------------
>
> Key: PIG-213
> URL: https://issues.apache.org/jira/browse/PIG-213
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.1.0
> Reporter: Vadim Geshel
> Priority: Minor
> Attachments: logging.patch
>
>
> LogFactory.getLog called from the constructor of Tuple accounts for significant percentage of my job's running time. The proposed fix is to make the Log fields static (which is generally standard practice).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-213) Non-static Log objects in
org.apache.pig.data.* classes are inefficient
Posted by "Mathieu Poumeyrol (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590561#action_12590561 ]
Mathieu Poumeyrol commented on PIG-213:
---------------------------------------
Yes, I actualy had a similar patch ready. I measured a 2 figures percentage of time spent on the logger instantiation on some processes...
> Non-static Log objects in org.apache.pig.data.* classes are inefficient
> -----------------------------------------------------------------------
>
> Key: PIG-213
> URL: https://issues.apache.org/jira/browse/PIG-213
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.1.0
> Reporter: Vadim Geshel
> Priority: Minor
> Attachments: logging.patch
>
>
> LogFactory.getLog called from the constructor of Tuple accounts for significant percentage of my job's running time. The proposed fix is to make the Log fields static (which is generally standard practice).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (PIG-213) Non-static Log objects in org.apache.pig.data.* classes are inefficient
Posted by Mathieu Poumeyrol <po...@idm.fr>.
Agreed. I have indeed made the same patch on my side. I have measured
two figures percentage of runtime spent in the data.* logger
instantiation.
Le 18 avr. 08 à 20:08, Vadim Geshel (JIRA) a écrit :
>
> [ https://issues.apache.org/jira/browse/PIG-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Vadim Geshel updated PIG-213:
> -----------------------------
>
> Status: Patch Available (was: Open)
>
>> Non-static Log objects in org.apache.pig.data.* classes are
>> inefficient
>> -----------------------------------------------------------------------
>>
>> Key: PIG-213
>> URL: https://issues.apache.org/jira/browse/PIG-213
>> Project: Pig
>> Issue Type: Bug
>> Components: impl
>> Affects Versions: 0.1.0
>> Reporter: Vadim Geshel
>> Priority: Minor
>> Attachments: logging.patch
>>
>>
>> LogFactory.getLog called from the constructor of Tuple accounts for
>> significant percentage of my job's running time. The proposed fix
>> is to make the Log fields static (which is generally standard
>> practice).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Updated: (PIG-213) Non-static Log objects in
org.apache.pig.data.* classes are inefficient
Posted by "Vadim Geshel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vadim Geshel updated PIG-213:
-----------------------------
Status: Patch Available (was: Open)
> Non-static Log objects in org.apache.pig.data.* classes are inefficient
> -----------------------------------------------------------------------
>
> Key: PIG-213
> URL: https://issues.apache.org/jira/browse/PIG-213
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.1.0
> Reporter: Vadim Geshel
> Priority: Minor
> Attachments: logging.patch
>
>
> LogFactory.getLog called from the constructor of Tuple accounts for significant percentage of my job's running time. The proposed fix is to make the Log fields static (which is generally standard practice).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-213) Non-static Log objects in
org.apache.pig.data.* classes are inefficient
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590548#action_12590548 ]
Benjamin Reed commented on PIG-213:
-----------------------------------
+1 Good catch.
> Non-static Log objects in org.apache.pig.data.* classes are inefficient
> -----------------------------------------------------------------------
>
> Key: PIG-213
> URL: https://issues.apache.org/jira/browse/PIG-213
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.1.0
> Reporter: Vadim Geshel
> Priority: Minor
> Attachments: logging.patch
>
>
> LogFactory.getLog called from the constructor of Tuple accounts for significant percentage of my job's running time. The proposed fix is to make the Log fields static (which is generally standard practice).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-213) Non-static Log objects in
org.apache.pig.data.* classes are inefficient
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-213:
---------------------------
Resolution: Fixed
Fix Version/s: 0.1.0
Status: Resolved (was: Patch Available)
Patch checked in at revision 649710.. Thank Vadim for contributing.
> Non-static Log objects in org.apache.pig.data.* classes are inefficient
> -----------------------------------------------------------------------
>
> Key: PIG-213
> URL: https://issues.apache.org/jira/browse/PIG-213
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.1.0
> Reporter: Vadim Geshel
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: logging.patch
>
>
> LogFactory.getLog called from the constructor of Tuple accounts for significant percentage of my job's running time. The proposed fix is to make the Log fields static (which is generally standard practice).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.