You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2013/06/03 01:30:20 UTC
[jira] [Commented] (SLING-2897) [LOG] Enhance web console plugin
with edit feature
[ https://issues.apache.org/jira/browse/SLING-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13672716#comment-13672716 ]
Felix Meschberger commented on SLING-2897:
------------------------------------------
Thank you very much for the patch.
While I appreciate the goal of inline editing, I am a bit concerned about the implementation:
(a) The LogConfigManager now has a ConfigurationAdmin service dependency; which sounds like missing separation of concern. At the very least the service reference should be retrieved with the class name as a string (otherwise the logging will only be available when the Configuration Admin API is available). Plus reading and writing the configuration should be moved to the SlingLogPanel (the actual Web Console Plugin) class. The LogConfigManager should really only consume configuration and not be a management agent.
(b) Having the login form defined, we basically have two locations where we map the configuration properties to fields/values: The MetaType definintion class used by the Web Console's Configuration Panel (and other MetaType Service consumers) and the new form definition in the SlingLogPanel. I am a bit concerned, that these two locations may become disconnected leading to all sorts of problems.
While the first problem can be solved I am not sure about the second one.
> [LOG] Enhance web console plugin with edit feature
> --------------------------------------------------
>
> Key: SLING-2897
> URL: https://issues.apache.org/jira/browse/SLING-2897
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Affects Versions: Commons Log 3.0.0
> Reporter: Bjoern Weide
> Priority: Minor
> Attachments: org.apache.sling.commons.log.patch
>
>
> The current web console plugin only lists the configured loggers but links for the actual configuration to the OSGi Configuration Manager.
> It should be improved so the logging configuration can be edited in the web console plugin directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira