You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/18 10:47:25 UTC
[GitHub] [arrow] jpedroantunes opened a new pull request #10741: ARROW-13374: [C++][Gandiva] Implement XOR function alias on Gandiva
jpedroantunes opened a new pull request #10741:
URL: https://github.com/apache/arrow/pull/10741
Actually, there is no XOR function alias on Gandiva.
This PR adds it and also add projector tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10741: ARROW-13374: [C++][Gandiva] Implement XOR function alias on Gandiva
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10741:
URL: https://github.com/apache/arrow/pull/10741#issuecomment-882036771
https://issues.apache.org/jira/browse/ARROW-13374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ViniciusSouzaRoque commented on a change in pull request #10741: ARROW-13374: [C++][Gandiva] Implement XOR function alias on Gandiva
Posted by GitBox <gi...@apache.org>.
ViniciusSouzaRoque commented on a change in pull request #10741:
URL: https://github.com/apache/arrow/pull/10741#discussion_r756791012
##########
File path: cpp/src/gandiva/function_registry_string.cc
##########
@@ -51,7 +51,7 @@ std::vector<NativeFunction> GetStringFunctionRegistry() {
UNARY_OCTET_LEN_FN(octet_length, {}), UNARY_OCTET_LEN_FN(bit_length, {}),
- UNARY_UNSAFE_NULL_IF_NULL(char_length, {}, utf8, int32),
+ UNARY_UNSAFE_NULL_IF_NULL(char_length, ({"character_length"}), utf8, int32),
Review comment:
Hi Projjal,
I go continue this PR.
I really don't know why have this. i go remove!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] projjal commented on a change in pull request #10741: ARROW-13374: [C++][Gandiva] Implement XOR function alias on Gandiva
Posted by GitBox <gi...@apache.org>.
projjal commented on a change in pull request #10741:
URL: https://github.com/apache/arrow/pull/10741#discussion_r704109276
##########
File path: cpp/src/gandiva/function_registry_string.cc
##########
@@ -51,7 +51,7 @@ std::vector<NativeFunction> GetStringFunctionRegistry() {
UNARY_OCTET_LEN_FN(octet_length, {}), UNARY_OCTET_LEN_FN(bit_length, {}),
- UNARY_UNSAFE_NULL_IF_NULL(char_length, {}, utf8, int32),
+ UNARY_UNSAFE_NULL_IF_NULL(char_length, ({"character_length"}), utf8, int32),
Review comment:
why the parenthesis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org