You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/03/20 16:30:19 UTC

[royale-asjs] branch develop updated: basic-itemrenderermousecontroller: fix ItemRenderers not responding to mouse events when positioner has more size than the inner element like in Jewel TabBar (fix #766)

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 902227f  basic-itemrenderermousecontroller: fix ItemRenderers not responding to mouse events when positioner has more size than the inner element like in Jewel TabBar (fix #766)
902227f is described below

commit 902227fbcc0ab8802de66df8daa08e5e5a4c3800
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Fri Mar 20 17:30:14 2020 +0100

    basic-itemrenderermousecontroller: fix ItemRenderers not responding to mouse events when positioner has more size than the inner element like in Jewel TabBar (fix #766)
---
 .../controllers/ItemRendererMouseController.as     | 37 +++++++++++-----------
 1 file changed, 19 insertions(+), 18 deletions(-)

diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
index c40e599..5be4ed5 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
@@ -18,25 +18,26 @@
 ////////////////////////////////////////////////////////////////////////////////
 package org.apache.royale.html.beads.controllers
 {
-	import org.apache.royale.core.IBeadController;
-	import org.apache.royale.core.IIndexedItemRenderer;
-	import org.apache.royale.core.ISelectableItemRenderer;
-	import org.apache.royale.core.IStrand;
-COMPILE::SWF {
+	COMPILE::SWF {
 	import org.apache.royale.events.Event;
 	import org.apache.royale.events.MouseEvent;
-}
-COMPILE::JS {
+	}
+	COMPILE::JS {
+	import goog.events;
+	import goog.events.Event;
+	import goog.events.EventType;
+
 	import org.apache.royale.core.UIBase;
 	import org.apache.royale.core.WrappedHTMLElement;
 	import org.apache.royale.events.BrowserEvent;
-	import goog.events.Event;
-	import goog.events.EventType;
-	import goog.events;
-}
+	}
+	import org.apache.royale.core.IBeadController;
+	import org.apache.royale.core.IIndexedItemRenderer;
+	import org.apache.royale.core.ISelectableItemRenderer;
+	import org.apache.royale.core.IStrand;
 	import org.apache.royale.events.ItemClickedEvent;
-	import org.apache.royale.utils.sendEvent;
 	import org.apache.royale.utils.getSelectionRenderBead;
+	import org.apache.royale.utils.sendEvent;
 
 	/**
 	 *  The ItemRendererMouseController class can mouse events in itemRenderers. This
@@ -89,13 +90,13 @@ COMPILE::JS {
 			}
 				
 			COMPILE::JS {
-				var element:WrappedHTMLElement = (_strand as UIBase).element;
+				var positioner:WrappedHTMLElement = (_strand as UIBase).positioner;
 				
-				goog.events.listen(element, goog.events.EventType.MOUSEOVER, this.handleMouseOver);
-				goog.events.listen(element, goog.events.EventType.MOUSEOUT, this.handleMouseOut);
-				goog.events.listen(element, goog.events.EventType.MOUSEDOWN, this.handleMouseDown);
-				goog.events.listen(element, goog.events.EventType.CLICK, this.handleMouseClick);
-				goog.events.listen(element, goog.events.EventType.MOUSEUP, this.handleMouseUp);
+				goog.events.listen(positioner, goog.events.EventType.MOUSEOVER, this.handleMouseOver);
+				goog.events.listen(positioner, goog.events.EventType.MOUSEOUT, this.handleMouseOut);
+				goog.events.listen(positioner, goog.events.EventType.MOUSEDOWN, this.handleMouseDown);
+				goog.events.listen(positioner, goog.events.EventType.CLICK, this.handleMouseClick);
+				goog.events.listen(positioner, goog.events.EventType.MOUSEUP, this.handleMouseUp);
 			}
 		}