You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ro...@apache.org on 2018/12/12 16:19:31 UTC
[3/4] james-project git commit: JAMES-2613 Log real STMP errors
JAMES-2613 Log real STMP errors
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/886122e3
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/886122e3
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/886122e3
Branch: refs/heads/master
Commit: 886122e34bd3bd961ebd4e98bb7e4010c03bf916
Parents: 8051692
Author: Raphael Ouazana <ra...@linagora.com>
Authored: Wed Nov 28 12:56:13 2018 +0100
Committer: Raphael Ouazana <ra...@linagora.com>
Committed: Wed Dec 12 17:17:29 2018 +0100
----------------------------------------------------------------------
.../protocols/api/handler/CommandDispatcher.java | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/886122e3/protocols/api/src/main/java/org/apache/james/protocols/api/handler/CommandDispatcher.java
----------------------------------------------------------------------
diff --git a/protocols/api/src/main/java/org/apache/james/protocols/api/handler/CommandDispatcher.java b/protocols/api/src/main/java/org/apache/james/protocols/api/handler/CommandDispatcher.java
index da59a3a..b271e13 100644
--- a/protocols/api/src/main/java/org/apache/james/protocols/api/handler/CommandDispatcher.java
+++ b/protocols/api/src/main/java/org/apache/james/protocols/api/handler/CommandDispatcher.java
@@ -142,20 +142,23 @@ public class CommandDispatcher<SessionT extends ProtocolSession> implements Exte
@Override
public Response onLine(SessionT session, ByteBuffer line) {
-
+ Request request;
try {
- Request request = parseRequest(session, line);
+ request = parseRequest(session, line);
if (request == null) {
return null;
}
- return dispatchCommandHandlers(session, request);
} catch (Exception e) {
LOGGER.debug("Unable to parse request", e);
return session.newFatalErrorResponse();
- }
-
-
+ }
+ try {
+ return dispatchCommandHandlers(session, request);
+ } catch (Exception e) {
+ LOGGER.error("Error dispatching command for request {}", request.getCommand(), e);
+ return session.newFatalErrorResponse();
+ }
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org