You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David James <st...@gmail.com> on 2004/09/18 22:07:03 UTC

[PATCH] Name of Java Install Target Should Be Determined By 'Install' Property

* build/generator/gen_base.py
  (gen_base.TargetJavaClasses, gen_base.TargetJavaHeaders): Make it so
that the name of the java install targets are determined by the
'install' property. (This makes Java targets consistent with the other
targets)
* build.conf: 
 (install-swig-java-api, install-swig-java-tests): Add an "install"
property to swig-java-api and swig-java-tests to accomodate the above
change

Re: [PATCH] Name of Java Install Target Should Be Determined By 'Install' Property

Posted by David James <ja...@gmail.com>.
> No problem!  I noticed that the last of those three was already
> referenced by issue #2040, so left that one alone.  I also thought the
> first and second patches had been attached to issues #2040 and #2039
> respectively, but looking more closely, they haven't.  Would you be
> willing to update those issues with references to the patches, if that's
> the appropriate place for them?
Done. Thanks! Hopefully this will draw more attention to my patches

-- 
http://www.cs.toronto.edu/~james

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Name of Java Install Target Should Be Determined By 'Install' Property

Posted by Michael W Thelen <th...@cs.utah.edu>.
David James wrote:
> Thanks Michael! I also have three other patches that haven't received
> responses yet. Should we file them as issues?
> 
> [PATCH] Allow users to test JavaHL bindings before installation
> <http://www.contactor.se/~dast/svn/archive-2004-09/0654.shtml>
> [PATCH] Add in missing javahl-java and javahl-javah dependencies
> <http://www.contactor.se/~dast/svn/archive-2004-09/0653.shtml>
> [PATCH] Add javahl-javah to libsvnjavahl dependencies
> <http://www.contactor.se/~dast/svn/archive-2004-09/0650.shtml>

No problem!  I noticed that the last of those three was already 
referenced by issue #2040, so left that one alone.  I also thought the 
first and second patches had been attached to issues #2040 and #2039 
respectively, but looking more closely, they haven't.  Would you be 
willing to update those issues with references to the patches, if that's 
the appropriate place for them?

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

Re: [PATCH] Name of Java Install Target Should Be Determined By 'Install' Property

Posted by David James <ja...@gmail.com>.
Thanks Michael! I also have three other patches that haven't received
responses yet. Should we file them as issues?

[PATCH] Allow users to test JavaHL bindings before installation
<http://www.contactor.se/~dast/svn/archive-2004-09/0654.shtml>
[PATCH] Add in missing javahl-java and javahl-javah dependencies
<http://www.contactor.se/~dast/svn/archive-2004-09/0653.shtml>
[PATCH] Add javahl-javah to libsvnjavahl dependencies
<http://www.contactor.se/~dast/svn/archive-2004-09/0650.shtml>

On Wed, 06 Oct 2004 21:36:15 -0600, Michael W Thelen
<th...@cs.utah.edu> wrote:
> David James wrote:
> > * build/generator/gen_base.py
> >   (gen_base.TargetJavaClasses, gen_base.TargetJavaHeaders): Make it so
> > that the name of the java install targets are determined by the
> > 'install' property. (This makes Java targets consistent with the other
> > targets)
> > * build.conf:
> >  (install-swig-java-api, install-swig-java-tests): Add an "install"
> > property to swig-java-api and swig-java-tests to accomodate the above
> > change
> 
> Thanks for the patch.  I've filed it as issue 2083:
> http://subversion.tigris.org/issues/show_bug.cgi?id=2083
> 
> --
> Michael W Thelen
> It is a mistake to think you can solve any major problems just with
> potatoes.       -- Douglas Adams
> 
> 
> 


-- 
http://www.cs.toronto.edu/~james

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Name of Java Install Target Should Be Determined By 'Install' Property

Posted by Michael W Thelen <th...@cs.utah.edu>.
David James wrote:
> * build/generator/gen_base.py
>   (gen_base.TargetJavaClasses, gen_base.TargetJavaHeaders): Make it so
> that the name of the java install targets are determined by the
> 'install' property. (This makes Java targets consistent with the other
> targets)
> * build.conf: 
>  (install-swig-java-api, install-swig-java-tests): Add an "install"
> property to swig-java-api and swig-java-tests to accomodate the above
> change

Thanks for the patch.  I've filed it as issue 2083:
http://subversion.tigris.org/issues/show_bug.cgi?id=2083

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams