You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/04/13 14:55:21 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #4926: feat(framework): backend support cognito
warren830 opened a new pull request, #4926:
URL: https://github.com/apache/incubator-devlake/pull/4926
### Summary
Modify backend to support cognito
### Does this close any open issues?
Closes xx
### Screenshots
login success
get blueprints with correct authorization:
<img width="1049" alt="image" src="https://user-images.githubusercontent.com/39366025/231799486-c55aa208-7df3-4810-9bbf-88f0580c3d96.png">
get blueprints with wrong authorization:
<img width="1060" alt="image" src="https://user-images.githubusercontent.com/39366025/231799567-95fee942-cac2-41a7-bc85-4e9c6cd99e91.png">
get blueprints with no authorization:
<img width="1035" alt="image" src="https://user-images.githubusercontent.com/39366025/231799658-c9d2b05d-337e-407a-8eae-855aa75e4466.png">
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4926: feat(framework): backend support cognito
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #4926:
URL: https://github.com/apache/incubator-devlake/pull/4926#discussion_r1166228551
##########
backend/server/services/cognito.go:
##########
@@ -0,0 +1,187 @@
+/*
Review Comment:
good call.
I would prefer the package to be called `auth`, and it could offer multiple auth mechanisms in the future, including `cognito` and others like `OAuth` and `SAML`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4926: feat(framework): backend support cognito
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 merged PR #4926:
URL: https://github.com/apache/incubator-devlake/pull/4926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #4926: feat(framework): backend support cognito
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on code in PR #4926:
URL: https://github.com/apache/incubator-devlake/pull/4926#discussion_r1166196174
##########
backend/server/services/cognito.go:
##########
@@ -0,0 +1,187 @@
+/*
Review Comment:
I'd define a new package called aws, and put all aws-facing code in there. It's more organized that way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4926: feat(framework): backend support cognito
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on code in PR #4926:
URL: https://github.com/apache/incubator-devlake/pull/4926#discussion_r1166238283
##########
backend/server/services/cognito.go:
##########
@@ -0,0 +1,187 @@
+/*
Review Comment:
OK, will fix it in the next pr, as I just created a new pr for frontend to support cognito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org