[GitHub] [airflow] ashb commented on a change in pull request #5668: [AIRFLOW-5055] support setting kubernetes_environment_variables config section from env var

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5668: [AIRFLOW-5055] support setting kubernetes_environment_variables config section from env var
URL: https://github.com/apache/airflow/pull/5668#discussion_r310033498
 
 

 ##########
 File path: airflow/configuration.py
 ##########
 @@ -398,8 +400,11 @@ def as_dict(
                     opt = opt.replace('%', '%%')
                 if display_source:
                     opt = (opt, 'env var')
-                cfg.setdefault(section.lower(), OrderedDict()).update(
-                    {key.lower(): opt})
+
+                section = section.lower()
+                if section != 'kubernetes_environment_variables':
 
 Review comment:
   Why are we treating this one section differently? At the _very_ least we need a code comment here saying why, but ideally I'd like to not have any special case here if we can avoid it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services