You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/02/08 06:52:35 UTC

Review Request 56430: incorrect imports in hive-next view

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56430/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19913
    https://issues.apache.org/jira/browse/AMBARI-19913


Repository: ambari


Description
-------

corrected the imports and packages.


Diffs
-----

  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java 355ed6a 
  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java 0826945 
  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java 72f3b7a 
  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java 4c1cb2b 
  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java a440e51 
  contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java 1613b05 

Diff: https://reviews.apache.org/r/56430/diff/


Testing
-------

manual testing done.


Thanks,

Nitiraj Rathore


Re: Review Request 56430: incorrect imports in hive-next view

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56430/#review164849
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 8, 2017, 6:52 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56430/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19913
>     https://issues.apache.org/jira/browse/AMBARI-19913
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> corrected the imports and packages.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java 355ed6a 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java 0826945 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java 72f3b7a 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java 4c1cb2b 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java a440e51 
>   contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java 1613b05 
> 
> Diff: https://reviews.apache.org/r/56430/diff/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 56430: incorrect imports in hive-next view

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56430/#review164850
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 8, 2017, 6:52 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56430/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19913
>     https://issues.apache.org/jira/browse/AMBARI-19913
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> corrected the imports and packages.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java 355ed6a 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java 0826945 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java 72f3b7a 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java 4c1cb2b 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java a440e51 
>   contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java 1613b05 
> 
> Diff: https://reviews.apache.org/r/56430/diff/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 56430: incorrect imports in hive-next view

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56430/#review164854
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 8, 2017, 6:52 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56430/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19913
>     https://issues.apache.org/jira/browse/AMBARI-19913
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> corrected the imports and packages.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java 355ed6a 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java 0826945 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java 72f3b7a 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java 4c1cb2b 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java a440e51 
>   contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java 1613b05 
> 
> Diff: https://reviews.apache.org/r/56430/diff/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>