[GitHub] [bahir-flink] netsi commented on a diff in pull request #155: [BAHIR-315] Redis connector: add Support for SSL connections for cluster

[GitBox <gi...@apache.org>]

netsi commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r992533025


##########
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##########
@@ -78,7 +79,25 @@ public void testRedisClusterDownBehavior() throws Exception {
             .setMaxTotal(1)
             .setMinIdle(1).build();
 
-        testDownBehavior(wrongJedisClusterConfig);
+        RedisSink<Tuple2<String, String>> redisSink = new RedisSink<>(wrongJedisClusterConfig,

Review Comment:
   The exception instance type has changed in the newer version. Previously the cluster and non cluster mode had the same type `JedisConnectionException` and now it is `JedisClusterOperationException`.
   
   https://github.com/redis/jedis/blob/master/docs/3to4.md
   
   ```
   All JedisCluster constructors now throw a JedisClusterOperationException if unable to connect to any of the provided HostAndPort(s). 
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org