You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/12/28 02:06:53 UTC
Review Request 64847: Added collection of example framework flag
definitions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
Bugs: MESOS-8357
https://issues.apache.org/jira/browse/MESOS-8357
Repository: mesos
Description
-------
Adds a set if flags exclusively used by our example frameworks. This
enhancement aids in unifying the user experience when tinkering with
our examples.
Diffs
-----
src/examples/example_framework_flags.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/64847/diff/1/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 64847: Added collection of example framework flag
definitions.
Posted by Till Toenshoff <to...@me.com>.
> On Jan. 9, 2018, 1:29 a.m., Vinod Kone wrote:
> > src/examples/example_framework_flags.hpp
> > Lines 32 (patched)
> > <https://reviews.apache.org/r/64847/diff/1/?file=1928736#file1928736line32>
> >
> > It's not clear to me why you broke down the flags like this? Also, not clear why v0 and v1 have different flags. Can you provide more context?
>
> Till Toenshoff wrote:
> The breakdown happened on the basis of existing example framework implementations and the features they offered. Formerly V0 example frameworks used an explicit flag to signal authentication while the V1 examples simply used the existence of a secret for enabling authentication.
> Guess we can go for such flag everywhere to not close out ticket based authentication (which might not even need a secret).
Simplified the grouping now.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195007
-----------------------------------------------------------
On Jan. 9, 2018, 3:20 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64847/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2018, 3:20 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-8357
> https://issues.apache.org/jira/browse/MESOS-8357
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set if flags exclusively used by our example frameworks. This
> enhancement aids in unifying the user experience when tinkering with
> our examples.
>
>
> Diffs
> -----
>
> src/examples/flags.hpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64847/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64847: Added collection of example framework flag
definitions.
Posted by Till Toenshoff <to...@me.com>.
> On Jan. 9, 2018, 1:29 a.m., Vinod Kone wrote:
> > src/examples/example_framework_flags.hpp
> > Lines 32 (patched)
> > <https://reviews.apache.org/r/64847/diff/1/?file=1928736#file1928736line32>
> >
> > It's not clear to me why you broke down the flags like this? Also, not clear why v0 and v1 have different flags. Can you provide more context?
The breakdown happened on the basis of existing example framework implementations and the features they offered. Formerly V0 example frameworks used an explicit flag to signal authentication while the V1 examples simply used the existence of a secret for enabling authentication.
Guess we can go for such flag everywhere to not close out ticket based authentication (which might not even need a secret).
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195007
-----------------------------------------------------------
On Dec. 28, 2017, 2:06 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64847/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2017, 2:06 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-8357
> https://issues.apache.org/jira/browse/MESOS-8357
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set if flags exclusively used by our example frameworks. This
> enhancement aids in unifying the user experience when tinkering with
> our examples.
>
>
> Diffs
> -----
>
> src/examples/example_framework_flags.hpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64847/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64847: Added collection of example framework flag
definitions.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195007
-----------------------------------------------------------
src/examples/example_framework_flags.hpp
Lines 17 (patched)
<https://reviews.apache.org/r/64847/#comment274105>
I would just name the file `flags.cpp` to be consistent with how we did master and agent flags? You would also need to change the MACRO here correspondingly.
src/examples/example_framework_flags.hpp
Lines 32 (patched)
<https://reviews.apache.org/r/64847/#comment274106>
It's not clear to me why you broke down the flags like this? Also, not clear why v0 and v1 have different flags. Can you provide more context?
- Vinod Kone
On Dec. 28, 2017, 2:06 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64847/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2017, 2:06 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-8357
> https://issues.apache.org/jira/browse/MESOS-8357
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set if flags exclusively used by our example frameworks. This
> enhancement aids in unifying the user experience when tinkering with
> our examples.
>
>
> Diffs
> -----
>
> src/examples/example_framework_flags.hpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64847/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64847: Added collection of example framework flag
definitions.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195037
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On Jan. 9, 2018, 3:20 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64847/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2018, 3:20 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-8357
> https://issues.apache.org/jira/browse/MESOS-8357
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set if flags exclusively used by our example frameworks. This
> enhancement aids in unifying the user experience when tinkering with
> our examples.
>
>
> Diffs
> -----
>
> src/examples/flags.hpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64847/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64847: Added collection of example framework flag
definitions.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195249
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 9, 2018, 3:20 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64847/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2018, 3:20 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-8357
> https://issues.apache.org/jira/browse/MESOS-8357
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set if flags exclusively used by our example frameworks. This
> enhancement aids in unifying the user experience when tinkering with
> our examples.
>
>
> Diffs
> -----
>
> src/examples/flags.hpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64847/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64847: Added collection of example framework flag
definitions.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195511
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 15, 2018, 12:29 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64847/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2018, 12:29 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-8357
> https://issues.apache.org/jira/browse/MESOS-8357
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set if flags exclusively used by our example frameworks. This
> enhancement aids in unifying the user experience when tinkering with
> our examples.
>
>
> Diffs
> -----
>
> src/examples/flags.hpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64847/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64847: Added collection of example framework flag
definitions.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/
-----------------------------------------------------------
(Updated Jan. 15, 2018, 12:29 a.m.)
Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
Changes
-------
Unified the flags further.
Bugs: MESOS-8357
https://issues.apache.org/jira/browse/MESOS-8357
Repository: mesos
Description
-------
Adds a set if flags exclusively used by our example frameworks. This
enhancement aids in unifying the user experience when tinkering with
our examples.
Diffs (updated)
-----
src/examples/flags.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/64847/diff/3/
Changes: https://reviews.apache.org/r/64847/diff/2-3/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 64847: Added collection of example framework flag
definitions.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/
-----------------------------------------------------------
(Updated Jan. 9, 2018, 3:20 a.m.)
Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
Bugs: MESOS-8357
https://issues.apache.org/jira/browse/MESOS-8357
Repository: mesos
Description
-------
Adds a set if flags exclusively used by our example frameworks. This
enhancement aids in unifying the user experience when tinkering with
our examples.
Diffs (updated)
-----
src/examples/flags.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/64847/diff/2/
Changes: https://reviews.apache.org/r/64847/diff/1-2/
Testing
-------
make check
Thanks,
Till Toenshoff