You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Raul Gutierrez Segales (JIRA)" <ji...@apache.org> on 2013/10/08 21:18:43 UTC

[jira] [Created] (ZOOKEEPER-1784) Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus

Raul Gutierrez Segales created ZOOKEEPER-1784:
-------------------------------------------------

             Summary: Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus
                 Key: ZOOKEEPER-1784
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1784
             Project: ZooKeeper
          Issue Type: Bug
    Affects Versions: 3.5.0
            Reporter: Raul Gutierrez Segales
            Assignee: Alexander Shraer


If you look at Learner#syncWithLeader:

{noformat}
            while (self.isRunning()) {
                readPacket(qp);
                switch(qp.getType()) {
.......

                case Leader.INFORM:
                case Leader.INFORMANDACTIVATE:
                    PacketInFlight packet = new PacketInFlight();
                    packet.hdr = new TxnHeader();

                    if (qp.getType() == Leader.COMMITANDACTIVATE) {
{noformat}

I guess "qp.getType() == Leader.COMMITANDACTIVATE" is a typo that should read "qp.getType() == Leader.INFORMANDACTIVATE".

Assigning to Alexander for now since this is part of ZOOKEEPER-107.




--
This message was sent by Atlassian JIRA
(v6.1#6144)