[jira] [Comment Edited] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and >=

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856643#comment-13856643 ] 

Andrew Purtell edited comment on HBASE-7226 at 12/25/13 6:54 PM:
-----------------------------------------------------------------

I did ask for the next couple of weeks that someone ping me before committing to 0.98. Just mention me in the JIRA using '[ ~ apurtell ]' (remove the spaces) and I will come take a look. Normally that won't be necessary. 

Edit: We/I don't need to freeze commits to make a release. The reason I asked for a heads up before commits to 0.98 from now on is I want to start attacking unit test failures and clean them up to 0.


was (Author: apurtell):
I did ask for the next couple of weeks that someone ping me before committing to 0.98. Just mention me in the JIRA using '[ ~ apurtell ]' (remove the spaces) and I will come take a look. Normally that won't be necessary. 

> HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and >=
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-7226
>                 URL: https://issues.apache.org/jira/browse/HBASE-7226
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>             Fix For: 0.94.16
>
>         Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch, HRegion_HBASE_7226_0.94.2.patch
>
>
> in HRegion.checkAndMutate, incorrect comparison results are used for <, <=, > and >=, as below:
>           switch (compareOp) {
>           case LESS:
>             matches = compareResult <= 0;  // should be '<' here
>             break;
>           case LESS_OR_EQUAL:
>             matches = compareResult < 0;  // should be '<=' here
>             break;
>           case EQUAL:
>             matches = compareResult == 0;
>             break;
>           case NOT_EQUAL:
>             matches = compareResult != 0;
>             break;
>           case GREATER_OR_EQUAL:
>             matches = compareResult > 0;  // should be '>=' here
>             break;
>           case GREATER:
>             matches = compareResult >= 0;  // should be '>' here
>             break;



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)