[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

[GitBox <gi...@apache.org>]

prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names 
URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328751043
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
 ##########
 @@ -357,76 +357,100 @@ public Builder withSpecId(int newSpecId) {
       return sourceColumn;
     }
 
-    public Builder identity(String sourceName) {
-      checkAndAddPartitionName(sourceName);
+
+    public Builder identity(String sourceName, String targetName) {
+      checkAndAddPartitionName(targetName);
 
 Review comment:
   done. Took out access to setting custom name on `identity` transform. Added check for non-identity transforms to disallow target names that exist in schema.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org