[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on pull request #755: (android) Removed waitForBeforeload flag as it prevents beforeLoad from being called on every GET request

[GitBox <gi...@apache.org>]

PDLMobileApps commented on pull request #755:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/755#issuecomment-684985007


   > @wvengen originally implemented the `beforeload` feature and [his PR comment](https://github.com/apache/cordova-plugin-inappbrowser/pull/276/files#r233077431) indicates that `waitForBeforeload` is necessary.
   > 
   > have you got an opinion on this @wvengen?
   
   We saw it was added on purpose and I believe it may had a specific goal. However, now it has the effect of preventing beforeLoad from being called on every GET request, which is quite a big deal.
   We removed it and we have been using the code in this PR successfully in production for a week.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org