[jira] [Commented] (HADOOP-15676) Cleanup TestSSLHttpServer

["Xiao Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645310#comment-16645310 ] 

Xiao Chen commented on HADOOP-15676:
------------------------------------

Thanks for revving, [~snemeth].

I understand it's existing code and you're just fixing a typo out of the message, and thanks for doing that. But since we're changing it, let's try to improve it for good.

IMO that try-catch-fail is bad, because only the exception message will be logged without the actual stack trace. To me, that's less information because otherwise one can just get to the failure point by looking at the stack trace - now this has to be done by text search and log correlation. The message itself doesn't seem to have substantial information either. If you'd like more information, we can log the ciphers before calling into the function.

pre-commits are gone but I think the checkstyle is complaining about {{oneEnabledCiphers}} and {{excludedCiphers}} not meeting the constant naming regex (needs to be upper case)

> Cleanup TestSSLHttpServer
> -------------------------
>
>                 Key: HADOOP-15676
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15676
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 2.6.0
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: HADOOP-15676.001.patch, HADOOP-15676.002.patch, HADOOP-15676.003.patch
>
>
> This issue will fix: 
> * Several typos in this class
> * Code is not very well readable in some of the places.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org