[GitHub] [kafka] Hangleton commented on a diff in pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

["Hangleton (via GitHub)" <gi...@apache.org>]

Hangleton commented on code in PR #13285:
URL: https://github.com/apache/kafka/pull/13285#discussion_r1116962787


##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -115,8 +115,8 @@ class SocketServer(val config: KafkaConfig,
   private var stopped = false
 
   // Socket server metrics
-  newGauge(s"${DataPlaneAcceptor.MetricPrefix}NetworkProcessorAvgIdlePercent", () => SocketServer.this.synchronized {
-    val dataPlaneProcessors = dataPlaneAcceptors.asScala.values.flatMap(a => a.processors)
+  newGauge(s"${DataPlaneAcceptor.MetricPrefix}NetworkProcessorAvgIdlePercent", () => {
+    val dataPlaneProcessors = dataPlaneAcceptors.asScala.values.flatMap(a => a.processors).toSeq

Review Comment:
   Maybe this comment would be useful in the code itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org