You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "MrMaxxan (via GitHub)" <gi...@apache.org> on 2023/08/22 07:56:22 UTC
[GitHub] [incubator-pekko-persistence-jdbc] MrMaxxan commented on a diff in pull request #44: Add Scala 3 support
MrMaxxan commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1301182553
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
Just checking: is it the merge of this PR that you will wait for until slick 3.5.0 is released or is it the release of the pekko-persistence-jdbc library that will wait for this? (I just wonder since I'm in a project where we are hoping for a stable release of pekko-persistence-jdbc for Scala 2 soon. 😁)
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
Just checking: is it the merge of this PR that you will wait for until slick 3.5.0 is released or is it the release of the pekko-persistence-jdbc library that will wait for this? (I just wonder since I'm in a project where we are hoping for a stable release of pekko-persistence-jdbc for Scala 2 soon. 😁)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org