You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/09/01 10:23:46 UTC
Re: Review Request 61947: Implemented handling of resource provider
offer operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/
-----------------------------------------------------------
(Updated Sept. 1, 2017, 12:23 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
While the resource provider manager is responsible to apply offer
operations by sending events to the respective resource providers,
the master takes care of accepting these operations. Hence, for local
resource providers the master sends an `ApplyResourceOperationMessage`
to the agent where the resource provider is running on. The agent
then relays the operation contained in the message to the resource
provider manager.
Diffs
-----
src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
src/messages/messages.proto dc4e19c08d671743f08223dcdf1dbc336b3940bd
src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094
src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
src/tests/resource_provider_manager_tests.cpp 83a1340fa16b19e3297a8c0ca413afc312de00ec
Diff: https://reviews.apache.org/r/61947/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 61947: Implemented handling of resource provider
offer operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/
-----------------------------------------------------------
(Updated Oct. 20, 2017, 2:54 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased, addressed issues: No longer alters `slave->totalResources` by calling `apply`.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
While the resource provider manager is responsible to apply offer
operations by sending events to the respective resource providers,
the master takes care of accepting these operations. Hence, for local
resource providers the master sends an `ApplyResourceOperationMessage`
to the agent where the resource provider is running on. The agent
then relays the operation contained in the message to the resource
provider manager.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
Diff: https://reviews.apache.org/r/61947/diff/4/
Changes: https://reviews.apache.org/r/61947/diff/3-4/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 61947: Implemented handling of resource provider
offer operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 3:54 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased on top of #63001.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
While the resource provider manager is responsible to apply offer
operations by sending events to the respective resource providers,
the master takes care of accepting these operations. Hence, for local
resource providers the master sends an `ApplyResourceOperationMessage`
to the agent where the resource provider is running on. The agent
then relays the operation contained in the message to the resource
provider manager.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
src/slave/slave.cpp 4d7dc8e9a3901b00103031e24e5d6328d0f2e2ad
Diff: https://reviews.apache.org/r/61947/diff/3/
Changes: https://reviews.apache.org/r/61947/diff/2-3/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 61947: Implemented handling of resource provider
offer operations.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/#review184930
-----------------------------------------------------------
Bad patch!
Reviews applied: [61947, 61946, 61810, 58021, 58047, 58048, 57999, 57998, 57997, 57911]
Failed command: python support/apply-reviews.py -n -r 58048
Error:
2017-09-08 03:05:40 URL:https://reviews.apache.org/r/58048/diff/raw/ [11585/11585] -> "58048.patch" [1]
error: patch failed: src/tests/mesos.hpp:875
error: src/tests/mesos.hpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19283/console
- Mesos Reviewbot
On Sept. 7, 2017, 12:27 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61947/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 12:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-7594
> https://issues.apache.org/jira/browse/MESOS-7594
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the resource provider manager is responsible to apply offer
> operations by sending events to the respective resource providers,
> the master takes care of accepting these operations. Hence, for local
> resource providers the master sends an `ApplyResourceOperationMessage`
> to the agent where the resource provider is running on. The agent
> then relays the operation contained in the message to the resource
> provider manager.
>
>
> Diffs
> -----
>
> src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce
> src/messages/messages.proto dc4e19c08d671743f08223dcdf1dbc336b3940bd
> src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094
> src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
> src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77
>
>
> Diff: https://reviews.apache.org/r/61947/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 61947: Implemented handling of resource provider
offer operations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/#review184844
-----------------------------------------------------------
ERROR: Failed to apply patch 57911. Please check http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61947/logs/apply-reviews.log for any relevant errors
Reviews applied: [57911, 57997, 57998, 57999, 58048, 58047, 58021, 61810, 61946, 61947]
Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61947/logs
- Mesos Reviewbot Windows
On Sept. 7, 2017, 12:27 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61947/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 12:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-7594
> https://issues.apache.org/jira/browse/MESOS-7594
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the resource provider manager is responsible to apply offer
> operations by sending events to the respective resource providers,
> the master takes care of accepting these operations. Hence, for local
> resource providers the master sends an `ApplyResourceOperationMessage`
> to the agent where the resource provider is running on. The agent
> then relays the operation contained in the message to the resource
> provider manager.
>
>
> Diffs
> -----
>
> src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce
> src/messages/messages.proto dc4e19c08d671743f08223dcdf1dbc336b3940bd
> src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094
> src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
> src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77
>
>
> Diff: https://reviews.apache.org/r/61947/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 61947: Implemented handling of resource provider
offer operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/
-----------------------------------------------------------
(Updated Sept. 7, 2017, 2:27 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
While the resource provider manager is responsible to apply offer
operations by sending events to the respective resource providers,
the master takes care of accepting these operations. Hence, for local
resource providers the master sends an `ApplyResourceOperationMessage`
to the agent where the resource provider is running on. The agent
then relays the operation contained in the message to the resource
provider manager.
Diffs (updated)
-----
src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce
src/messages/messages.proto dc4e19c08d671743f08223dcdf1dbc336b3940bd
src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094
src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77
Diff: https://reviews.apache.org/r/61947/diff/2/
Changes: https://reviews.apache.org/r/61947/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht