You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "wenbingshen (via GitHub)" <gi...@apache.org> on 2023/06/15 06:25:54 UTC
[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3988: Fix Journal Sync wrong stats
wenbingshen opened a new pull request, #3988:
URL: https://github.com/apache/bookkeeper/pull/3988
### Motivation
In Journal, we process `ForceWriteRequest` with batch as the smallest unit. When we rotate a Journal File, in the forceWriteRequests queue, we may contain a ForceWriteRequest of an old file, and shouldClose is true, and the last ForceWriteRequest in the queue is created by the new Jouranl file. When we batch process fwr, we only sync the last ForceWriteRequest to the disk, so that we can flash the previous fwr data of the file to the disk together. But for old files, when we process the fwr response, we will still process `closeFileIfNecessary`. Here we also sync the Journal files that are waiting for close, but here, we do not update `JournalSyncStats`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen closed pull request #3988: Fix Journal Sync wrong stats
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen closed pull request #3988: Fix Journal Sync wrong stats
URL: https://github.com/apache/bookkeeper/pull/3988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3988: Fix Journal Sync wrong stats
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3988:
URL: https://github.com/apache/bookkeeper/pull/3988#issuecomment-1599982057
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3988: Fix Journal Sync wrong stats
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3988:
URL: https://github.com/apache/bookkeeper/pull/3988#issuecomment-1596389896
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3988: Fix Journal Sync wrong stats
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3988:
URL: https://github.com/apache/bookkeeper/pull/3988#issuecomment-1594122603
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org