[jira] [Commented] (SENTRY-1056) Get service name from Kafka's server properties.

["Hao Hao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174707#comment-15174707 ] 

Hao Hao commented on SENTRY-1056:
---------------------------------

+1 LGTM. Thannks [~singhashish]!

> Get service name from Kafka's server properties.
> ------------------------------------------------
>
>                 Key: SENTRY-1056
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1056
>             Project: Sentry
>          Issue Type: Sub-task
>            Reporter: Ashish K Singh
>            Assignee: Ashish K Singh
>             Fix For: 1.7.0
>
>         Attachments: SENTRY-1056.001-kafka.patch
>
>
> KafkaAuthorizer is using a hard-coded service name, "kafka". This will work as long as there is only one Kafka cluster instance that is trying to authenticate with Sentry. This however, might not be always true. In order to identify each kafka cluster instance separately, during kafka authorizer's configuration kafka cluster name can be obtained from kafka configs and be used as a service name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)