You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/07 15:05:49 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #10115: [FLINK-14630] Re-enable logging for Yarn tests

tillrohrmann commented on a change in pull request #10115: [FLINK-14630] Re-enable logging for Yarn tests
URL: https://github.com/apache/flink/pull/10115#discussion_r343697236
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
 ##########
 @@ -304,11 +304,12 @@ public static File findFile(String startAt, FilenameFilter fnf) {
 
 	@Nonnull
 	YarnClusterDescriptor createYarnClusterDescriptor(org.apache.flink.configuration.Configuration flinkConfiguration) {
-		final YarnClusterDescriptor yarnClusterDescriptor = new YarnClusterDescriptor(
-			flinkConfiguration,
-			YARN_CONFIGURATION,
-			yarnClient,
-			true);
+		final YarnClusterDescriptor yarnClusterDescriptor = YarnTestUtils.createClusterDescriptorWithLogging(
+				CliFrontend.getConfigurationDirectoryFromEnv(),
 
 Review comment:
   ```suggestion
   				tempConfPathForSecureRun.getAbsolutePath(),
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services